Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #80544

Closed
wants to merge 26 commits into from

Commits on Dec 21, 2020

  1. Configuration menu
    Copy the full SHA
    799e822 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Improve test

    0urobor0s committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    f502263 View commit details
    Browse the repository at this point in the history
  2. Add error code

    0urobor0s committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    0c217a6 View commit details
    Browse the repository at this point in the history
  3. Formatting

    0urobor0s committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    d261176 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. Refactor

    0urobor0s committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    b3b74a9 View commit details
    Browse the repository at this point in the history
  2. Update and improve rustc_codegen_{llvm,ssa} docs

    These docs were very out of date and misleading. They even said that
    they codegen'd the *AST*!
    
    For some reason, the `rustc_codegen_ssa::base` docs were exactly
    identical to the `rustc_codegen_llvm::base` docs. They didn't really
    make sense, because they had LLVM-specific information even though
    `rustc_codegen_ssa` is supposed to be somewhat generic. So I removed
    them as they were misleading.
    camelid committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    5b32ab6 View commit details
    Browse the repository at this point in the history
  3. Fix tests

    0urobor0s committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    8a4e7a7 View commit details
    Browse the repository at this point in the history
  4. Fix tests

    0urobor0s committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    1990713 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Add #[track_caller] to bug! and register_renamed

    Before:
    
    ```
    thread 'rustc' panicked at 'compiler/rustc_lint/src/context.rs:267:18: invalid lint renaming of broken_intra_doc_links to rustdoc::broken_intra_doc_links', compiler/rustc_middle/src/util/bug.rs:34:26
    ```
    
    After:
    
    ```
    thread 'rustc' panicked at 'src/librustdoc/core.rs:455:24: invalid lint renaming of broken_intra_doc_links to rustdoc::broken_intra_doc_links', compiler/rustc_middle/src/util/bug.rs:35:26
    ```
    
    The reason I added it to `register_renamed` too is that any panic in
    that function will be the caller's fault.
    jyn514 committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    56ea926 View commit details
    Browse the repository at this point in the history
  2. bootstrap: never delete the tarball temporary directory

    Files in the temporary directory are used by ./x.py install.
    pietroalbini committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    bd3499b View commit details
    Browse the repository at this point in the history
  3. bootstrap: change the dist outputs to GeneratedTarball

    The struct will allow to store more context on the generated tarballs.
    pietroalbini committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    f02def8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f946b54 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    40bf3c0 View commit details
    Browse the repository at this point in the history
  6. Update LLVM

    - [GlobalISel][IRTranslator] Fix a crash when the use of an extractvalue is a non-dominated metadata use.
    - [asan] Use dynamic shadow memory position on Apple Silicon macOS
    tmandry committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    26daa65 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    947b279 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    27b81bf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5694b8e View commit details
    Browse the repository at this point in the history
  10. Fix typos.

    m-ou-se committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    4614cdd View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Rollup merge of rust-lang#79150 - m-ou-se:bye-bye-doc-comment-hack, r…

    …=jyn514
    
    Remove all doc_comment!{} hacks by using #[doc = expr] where needed.
    
    This replaces about 200 cases of
    
    `````rust
            doc_comment! {
                concat!("The smallest value that can be represented by this integer type.
    
    # Examples
    
    Basic usage:
    
    ```
    ", $Feature, "assert_eq!(", stringify!($SelfT), "::MIN, ", stringify!($Min), ");",
    $EndFeature, "
    ```"),
                #[stable(feature = "assoc_int_consts", since = "1.43.0")]
                pub const MIN: Self = !0 ^ ((!0 as $UnsignedT) >> 1) as Self;
            }
    `````
    by
    ```rust
            /// The smallest value that can be represented by this integer type.
            ///
            /// # Examples
            ///
            /// Basic usage:
            ///
            /// ```
            #[doc = concat!("assert_eq!(", stringify!($SelfT), "::MIN, ", stringify!($Min), ");")]
            /// ```
            #[stable(feature = "assoc_int_consts", since = "1.43.0")]
            pub const MIN: Self = !0 ^ ((!0 as $UnsignedT) >> 1) as Self;
    ```
    
    ---
    
    **Note:** For a usable diff, make sure to enable 'ignore whitspace': https://github.com/rust-lang/rust/pull/79150/files?diff=unified&w=1
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    7586279 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#80267 - 0urobor0s:ouro/61592, r=jyn514

    Rustdoc render public underscore_imports as Re-exports
    
    Fixes rust-lang#61592
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    00d66b2 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#80323 - camelid:codegen-base-docs, r=nagisa

    Update and improve `rustc_codegen_{llvm,ssa}` docs
    
    Fixes rust-lang#75342.
    
    These docs were very out of date and misleading. They even said that
    they codegen'd the *AST*!
    
    For some reason, the `rustc_codegen_ssa::base` docs were exactly
    identical to the `rustc_codegen_llvm::base` docs. They didn't really
    make sense, because they had LLVM-specific information even though
    `rustc_codegen_ssa` is supposed to be somewhat generic. So I removed
    them as they were misleading.
    
    r? `@pnkfelix` maybe?
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    26b8c0d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#80459 - mark-i-m:or-pat-reg, r=petrochenkov

    Implement edition-based macro :pat feature
    
    This PR does two things:
    1. Fixes the perf regression from rust-lang#80100 (comment)
    2. Implements `:pat2018` and `:pat2021` matchers, as described by `@joshtriplett`  in rust-lang#54883 (comment) behind the feature gate `edition_macro_pat`.
    
    r? `@petrochenkov`
    
    cc `@Mark-Simulacrum`
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    6452dd4 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#80500 - jyn514:track-caller, r=nagisa

    Add `#[track_caller]` to `bug!` and `register_renamed`
    
    Before:
    
    ```
    thread 'rustc' panicked at 'compiler/rustc_lint/src/context.rs:267:18: invalid lint renaming of broken_intra_doc_links to rustdoc::broken_intra_doc_links', compiler/rustc_middle/src/util/bug.rs:34:26
    ```
    
    After:
    
    ```
    thread 'rustc' panicked at 'src/librustdoc/core.rs:455:24: invalid lint renaming of broken_intra_doc_links to rustdoc::broken_intra_doc_links', compiler/rustc_middle/src/util/bug.rs:35:26
    ```
    
    The reason I added it to `register_renamed` too is that any panic in
    that function will be the caller's fault.
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    0d5fba7 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#80514 - pietroalbini:fix-install, r=Mark-Si…

    …mulacrum
    
    Fix broken ./x.py install
    
    During my tarball refactorings in rust-lang#79788 I changed the directory layout used by the tarball generation code, and that broke the other parts of rustbuild which hardcoded the paths of those directories. Namely, `./x.py install` relied on the uncompressed copy of the tarball left behind by `fabricate`/`rust-installer`, causing rust-lang#80494.
    
    While the easy fix for rust-lang#80494 would've been to just update the hardcoded paths to match the new structure, that fix would leave us in the same situation if we were to change the directory layout again in the future. Instead I refactored the code to return a `GeneratedTarball` struct as the output of all the dist steps, and I put all the paths the rest of rustbuild needs to care about in its fields. That way, future changes to `src/bootstrap/tarball.rs` will not break other stuff.
    
    This PR is best reviewed commit-by-commit.
    r? `@Mark-Simulacrum`
    `@rustbot` modify labels: beta-nominated beta-accepted T-release
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    bd54e4a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#80519 - max-heller:issue-80512-fix, r=varkor

    Take type defaults into account in suggestions to reorder generic parameters
    
    Fixes rust-lang#80512
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    41817ae View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#80526 - tmandry:up-llvm, r=nikic

    Update LLVM
    
    - [GlobalISel][IRTranslator] Fix a crash when the use of an extractvalue is a non-dominated metadata use.
    - [asan] Use dynamic shadow memory position on Apple Silicon macOS
    
    r? `@cuviper`
    Dylan-DPC committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    07ba9e9 View commit details
    Browse the repository at this point in the history