Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Option::map_or instead of open coding it #80464

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Use Option::map_or instead of open coding it #80464

merged 1 commit into from
Dec 30, 2020

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Dec 29, 2020

@rustbot modify labels +C-cleanup +T-compiler

@rustbot rustbot added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2020
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 29, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 29, 2020

📌 Commit 3dae414 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 29, 2020
@GuillaumeGomez
Rollup merge of rust-lang#80464 - LingMan:map_or, r=oli-obk
ba03726 
Use Option::map_or instead of open coding it

`@rustbot` modify labels +C-cleanup +T-compiler
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 29, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Dec 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2020
@bors
Auto merge of rust-lang#80503 - JohnTitor:rollup-b26vglu, r=JohnTitor
d107a87 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#79812 (Lint on redundant trailing semicolon after item)
 - rust-lang#80348 (remove redundant clones (clippy::redundant_clone))
 - rust-lang#80358 (Edit rustc_span documentation)
 - rust-lang#80457 (Add missing commas to `rustc_ast_pretty::pp` docs)
 - rust-lang#80461 (Add llvm-libunwind change to bootstrap CHANGELOG)
 - rust-lang#80464 (Use Option::map_or instead of open coding it)
 - rust-lang#80465 (Fix typo in ffi-pure.md)
 - rust-lang#80467 (More uses of the matches! macro)
 - rust-lang#80469 (Fix small typo in time comment)
 - rust-lang#80472 (Use sans-serif font for the "all items" page links)
 - rust-lang#80477 (Make forget intrinsic safe)
 - rust-lang#80482 (don't clone copy types)
 - rust-lang#80487 (don't redundantly repeat field names)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 30ddc91 into rust-lang:master Dec 30, 2020
@rustbot rustbot added this to the 1.51.0 milestone Dec 30, 2020
@LingMan LingMan deleted the map_or branch December 30, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LingMan @rust-highfive @oli-obk @bors @rustbot