Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline DebruijnIndex::hash_stable #80131

Closed

Conversation

LeSeulArtichaut
Copy link
Contributor

Last chance to fix the perf regression from #79169...

r? @ghost
cc @jackh726 @rylev

@jackh726
Copy link
Member

@bors try @rust-timer queue

Fingers crossed

@bors
Copy link
Contributor

bors commented Dec 17, 2020

⌛ Trying commit fdde4c8 with merge 676d1bd5188b2ac2bb17e0bafa1c0d77cccf2474...

@bors
Copy link
Contributor

bors commented Dec 17, 2020

☀️ Try build successful - checks-actions
Build commit: 676d1bd5188b2ac2bb17e0bafa1c0d77cccf2474 (676d1bd5188b2ac2bb17e0bafa1c0d77cccf2474)

@Mark-Simulacrum
Copy link
Member

@rust-timer build 676d1bd5188b2ac2bb17e0bafa1c0d77cccf2474

@rust-timer
Copy link
Collaborator

Queued 676d1bd5188b2ac2bb17e0bafa1c0d77cccf2474 with parent d23e084, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 17, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (676d1bd5188b2ac2bb17e0bafa1c0d77cccf2474): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 18, 2020
@bjorn3
Copy link
Member

bjorn3 commented Dec 18, 2020

This caused a slight regression.

@LeSeulArtichaut LeSeulArtichaut deleted the inline-hash branch February 18, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants