impl AsMut<[T]> for vec::IntoIter<T> #80028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `impl<T> AsMut<[T]> for vec::IntoIter<T>`, exposing the same behavior as `vec::IntoIter::as_mut_slice`, which has been stable since 1.15.0. https://doc.rust-lang.org/std/vec/struct.IntoIter.html#method.as_mut_slice See #72583, which added the `AsRef<[T]>` impl to `vec::IntoIter`. Adding this symmetric API. As a trait impl, this will be insta-stable.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
added
the
T-libs-api
|
r? @dtolnay for t-libs approval |
scottmcm
added
the
needs-fcp
dtolnay
reviewed
Dec 20, 2020
|
I don't have a concrete use for this trait impl. It just struck me as a missing implementation of a core trait for which an equivalent, long-stable API already exists. |
|
I think I would prefer not to add this in that case. Happy to reconsider if someone can show code where they would want to use this impl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
impl<T> AsMut<[T]> for vec::IntoIter<T>, exposing the samebehavior as
vec::IntoIter::as_mut_slice, which has been stable since1.15.0.
https://doc.rust-lang.org/std/vec/struct.IntoIter.html#method.as_mut_slice
See #72583, which added the
AsRef<[T]>impl tovec::IntoIter. Adding this symmetric API.As a trait impl, this will be insta-stable.