Add 'consider using' message to overflowing_literals #79981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-diagnostics
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
added
the
A-suggestion-diagnostics
|
Note that this doesn't produce a suggestion yet; that's next. |
Ironically, the overflowing_literals handler for binary or hex already had this message! You would think it would be the other way around :)
camelid
force-pushed
the
overflowing_literals-inference-error
branch
from
9712401 to
d00ca11
Compare
lcnr
approved these changes
Dec 14, 2020
compiler/rustc_lint/src/types.rs
Outdated
| if let Some(sugg_ty) = | ||
| get_type_suggestion(&cx.typeck_results().node_type(e.hir_id), v, negative) | ||
| { | ||
| err.help(&format!("consider using `{}` instead", sugg_ty)); |
There was a problem hiding this comment.
"using i8" sounds weird to me, maybe something like
Suggested change
| err.help(&format!("consider using `{}` instead", sugg_ty)); | |
| err.help(&format!("consider changing its type to `{}`", sugg_ty)); |
There was a problem hiding this comment.
I just copied-and-pasted this from the binary/hexadecimal error. If we change this one, we should probably change the other one too.
There was a problem hiding this comment.
hmm, yeah I would prefer us to change this as well. Do you have a preference here?
There was a problem hiding this comment.
What about
Suggested change
| err.help(&format!("consider using `{}` instead", sugg_ty)); | |
| err.help(&format!("consider using the `{}` type instead", sugg_ty)); |
or something like that?
There was a problem hiding this comment.
somehow deleted my original message. edit: that seems fine to me ^^ though I would slightly adjust the wording here
Suggested change
| err.help(&format!("consider using `{}` instead", sugg_ty)); | |
| err.help(&format!("consider using the type `{}` instead", sugg_ty)); |
There was a problem hiding this comment.
There are things like:
ty::Char => FfiUnsafe {
ty,
reason: "the `char` type has no C equivalent".into(),
help: Some("consider using `u32` or `libc::wchar_t` instead".into()),
},and
ty::Str => FfiUnsafe {
ty,
reason: "string slices have no C equivalent".into(),
help: Some("consider using `*const u8` and a length instead".into()),
},but those are for a different error so leaving them be.
camelid
added
the
S-waiting-on-author
camelid
removed
the
S-waiting-on-author
|
@bors r+ rollup |
|
📌 Commit a9b16c6 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 16, 2021
…nce-error, r=lcnr Add 'consider using' message to overflowing_literals Fixes rust-lang#79744. Ironically, the `overflowing_literals` handler for binary or hex already had this message! You would think it would be the other way around :) cc `@scottmcm`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 17, 2021
…nce-error, r=lcnr Add 'consider using' message to overflowing_literals Fixes rust-lang#79744. Ironically, the `overflowing_literals` handler for binary or hex already had this message! You would think it would be the other way around :) cc ``@scottmcm``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2021
…laumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#79981 (Add 'consider using' message to overflowing_literals) - rust-lang#82094 (To digit simplification) - rust-lang#82105 (Don't fail to remove files if they are missing) - rust-lang#82136 (Fix ICE: Use delay_span_bug for mismatched subst/hir arg) - rust-lang#82169 (Document that `assert!` format arguments are evaluated lazily) - rust-lang#82174 (Replace File::create and write_all with fs::write) - rust-lang#82196 (Add caveat to Path::display() about lossiness) - rust-lang#82198 (Use internal iteration in Iterator::is_sorted_by) - rust-lang#82204 (Update books) - rust-lang#82207 (rustdoc: treat edition 2021 as unstable) - rust-lang#82231 (Add long explanation for E0543) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79744.
Ironically, the
overflowing_literalshandler for binary or hex alreadyhad this message! You would think it would be the other way around :)
cc @scottmcm