Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the number of entries in UI test on tidy #79959

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Check the number of entries in UI test on tidy #79959

merged 1 commit into from
Dec 14, 2020

Conversation

JohnTitor
Copy link
Member

This helps #73494 to be resolved.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2020
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 12, 2020
petrochenkov
petrochenkov reviewed Dec 12, 2020
View reviewed changes
src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved
src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved
src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2020
@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2020
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2020
@petrochenkov
Copy link
Contributor

r=me with commits squashed.

@JohnTitor
Copy link
Member Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Dec 14, 2020

📌 Commit adda964 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 14, 2020
@Dylan-DPC
Rollup merge of rust-lang#79959 - JohnTitor:tidy-entries, r=petrochenkov
c3cf83b 
Check the number of entries in UI test on tidy

This helps rust-lang#73494 to be resolved.

r? `@petrochenkov`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 14, 2020
Closed
@bors
Copy link
Contributor

bors commented Dec 14, 2020

⌛ Testing commit adda964 with merge 3c45bff...

@bors
Copy link
Contributor

bors commented Dec 14, 2020

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 3c45bff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 14, 2020
@bors bors merged commit 3c45bff into rust-lang:master Dec 14, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 14, 2020
@JohnTitor JohnTitor deleted the tidy-entries branch December 14, 2020 12:08
@JohnTitor JohnTitor mentioned this pull request Dec 14, 2020
Open
2 tasks
@JohnTitor JohnTitor mentioned this pull request Dec 31, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Jan 11, 2021
Merged
@JohnTitor JohnTitor mentioned this pull request Mar 5, 2021
Merged
@JhonnyBillM JhonnyBillM mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@JohnTitor @petrochenkov @bors @rust-highfive @jyn514 @rustbot