Resolve enum field visibility correctly #79956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-resolve
|
r? @eddyb (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
T-compiler
camelid
commented
Dec 12, 2020
camelid
commented
Dec 12, 2020
| LL | foo::Pub {}; | ||
| | ^^^^^^^^ | ||
|
|
||
| error[E0063]: missing field `y` in initializer of `Enum` |
There was a problem hiding this comment.
This should probably print
error[E0063]: missing field `y` in initializer of `Enum::Variant`
but that's unrelated to this change.
(I'm leaving this as a todo for myself.)
camelid
force-pushed
the
variant-field-vis
branch
from
383fe5a to
013c498
Compare
jyn514
reviewed
Dec 12, 2020
petrochenkov
added
S-waiting-on-author
camelid
commented
Dec 12, 2020
camelid
added
S-waiting-on-review
|
Could you also squashing commits after addressing the comments? |
petrochenkov
added
S-waiting-on-author
camelid
added
S-waiting-on-review
|
I believe I have addressed all of your comments now. |
|
Thanks! |
petrochenkov
added
S-waiting-on-author
Previously, this code treated enum fields' visibility as if they were struct fields. However, that's not correct because the visibility of a struct field with `ast::VisibilityKind::Inherited` is private to the module it's defined in, whereas the visibility of an *enum* field with `ast::VisibilityKind::Inherited` is the visibility of the enum it belongs to.
camelid
force-pushed
the
variant-field-vis
branch
from
66690dd to
5ce3f4c
Compare
|
Squashed! |
camelid
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 5ce3f4c has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
camelid
added
the
beta-nominated
|
Nominating for beta-backport since this error comes up fairly frequently and the unfixed version is very confusing and annoying, and it's likely that it's even more so for newcomers. (The issue this fixed was P-high because of the reasons I listed.) |
rustbot
removed
the
beta-nominated
JohnTitor
added a commit
to JohnTitor/rust-semverver
that referenced
this pull request
Mar 31, 2021
rust-lang/rust#79956 improved enum's visibility and now we can check the visibility more precisely.
JohnTitor
added a commit
to JohnTitor/rust-semverver
that referenced
this pull request
Mar 31, 2021
rust-lang/rust#79956 improved enum's visibility and now we can check the visibility more precisely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79593. 🎉
Previously, this code treated enum fields' visibility as if they were
struct fields. However, that's not correct because the visibility of a
struct field with
ast::VisibilityKind::Inheritedis private to themodule it's defined in, whereas the visibility of an enum field with
ast::VisibilityKind::Inheritedis the visibility of the enum itbelongs to.