Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smarter E0390 #79772

Merged
merged 2 commits into from
Dec 7, 2020
Merged

smarter E0390 #79772

merged 2 commits into from
Dec 7, 2020

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Dec 6, 2020

Should fix #79760

I am fairly new to the compiler so am hoping I did things correctly :).

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2020
@camelid camelid added the A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`. label Dec 6, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2020

This is a really nice improvement in diagnostics, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 7, 2020

📌 Commit 67db0ea has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2020
@bors
Copy link
Contributor

bors commented Dec 7, 2020

⌛ Testing commit 67db0ea with merge 2b76c48...

@bors
Copy link
Contributor

bors commented Dec 7, 2020

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 2b76c48 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 7, 2020
@bors bors merged commit 2b76c48 into rust-lang:master Dec 7, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 7, 2020
@eopb eopb deleted the 79760-wrongly-speaks-of-methods branch December 7, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

Assignees

@oli-obk oli-obk

Labels
A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

Error wrongly trying to assign assoc const to primitive speaks of methods
6 participants
@eopb @rust-highfive @oli-obk @bors @camelid @rustbot