Rename `AllocRef` to `Allocator` and `(de)alloc` to `(de)allocate` #79286

TimDiekmann · 2020-11-22T01:18:39Z

Calling Box::alloc_ref and Vec::alloc_ref sounds like allocating a reference. To solve this ambiguity, this renames AllocRef to Allocator and alloc to allocate. For a more detailed explaination see rust-lang/wg-allocators#76.

closes rust-lang/wg-allocators#76

r? @KodrAus
@rustbot modify labels: +A-allocators +T-libs
@rustbot ping wg-allocators

rustbot · 2020-11-22T01:18:42Z

Error: Parsing ping command in comment failed: ...'tbot ping:' | error: no team specified at >| ' wg-alloca'...

Please let @rust-lang/release know if you're having trouble with this bot.

rustbot · 2020-11-22T01:18:54Z

Error: Only Rust team members can ping teams.

Please let @rust-lang/release know if you're having trouble with this bot.

TimDiekmann · 2020-11-22T01:20:06Z

Nice, I can't ping my own team. 🙁

cc @Amanieu @Lokathor @Wodann @CAD97 @scottjmaddox

bors · 2020-11-23T17:00:39Z

☔ The latest upstream changes (presumably #79186) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

bors · 2020-11-29T05:18:54Z

☔ The latest upstream changes (presumably #79529) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Wodann

This change looks good to me.

m-ou-se · 2020-12-04T13:53:58Z

@bors r=Lokathor,Wodann,m-ou-se

bors · 2020-12-04T13:53:59Z

📌 Commit 9274b37 has been approved by Lokathor,Wodann,m-ou-se

bors · 2020-12-04T14:02:36Z

⌛ Testing commit 9274b37 with merge 938c9f1415de9805ec074fca89c0c080ac7e4efe...

bors · 2020-12-04T18:17:36Z

💥 Test timed out

m-ou-se · 2020-12-04T18:23:53Z

Apparently the Apple runners are timing out again :(

@bors retry

bors · 2020-12-04T18:24:03Z

⌛ Testing commit 9274b37 with merge 5034e7a7bf3f5384025dc390c4804a23b160551a...

bors · 2020-12-04T20:07:09Z

⌛ Testing commit 9274b37 with merge 3ff10e7...

bors · 2020-12-04T22:19:17Z

☀️ Test successful - checks-actions
Approved by: Lokathor,Wodann,m-ou-se
Pushing 3ff10e7 to master...

rust-highfive · 2020-12-04T22:20:26Z

📣 Toolstate changed by #79286!

Tested on commit 3ff10e7.
Direct link to PR: #79286

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
💔 nomicon on windows: test-pass → test-fail (cc @Gankra @frewsxcv).
💔 nomicon on linux: test-pass → test-fail (cc @Gankra @frewsxcv).

@oli-obk

Tested on commit rust-lang/rust@3ff10e7. Direct link to PR: <rust-lang/rust#79286> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung). 💔 nomicon on windows: test-pass → test-fail (cc @Gankra @frewsxcv). 💔 nomicon on linux: test-pass → test-fail (cc @Gankra @frewsxcv).

Update to new core::alloc::Allocator interface This fixes the allocator test for the changes made to the allocator trait in `core` in rust-lang/rust#79286 See rust-lang/rust#79709

LeSeulArtichaut · 2020-12-06T13:29:15Z

Nice, I can't ping my own team. 🙁

Since you're a member of the rust-lang org, you can ping the team with a simple @-mention: @rust-lang/wg-allocators.
The @rustbot ping command is used for notification groups, which don't have a GitHub team, like the Cleanup Crew.

TimDiekmann · 2020-12-06T13:34:11Z

I have become a member since then, but thanks for the info!

The trait's identifier was changed in rust-lang/rust#79286.

Account for renaming AllocRef to Allocator on nightly `AllocRef` was renamed to `Allocator` in rust-lang/rust#79286.

Looks like the trait got renamed in rust-lang/rust#79286

rustbot added A-allocators Area: Custom and system allocators T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 22, 2020

rust-highfive assigned KodrAus Nov 22, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2020

Lokathor approved these changes Nov 22, 2020

View reviewed changes

Wodann approved these changes Dec 4, 2020

View reviewed changes

m-ou-se assigned m-ou-se and unassigned KodrAus Dec 4, 2020

Rename AllocRef to Allocator and (de)alloc to (de)allocate

9274b37

TimDiekmann force-pushed the rename-allocref branch from b74ceb6 to 9274b37 Compare December 4, 2020 13:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2020

bors merged commit 3ff10e7 into rust-lang:master Dec 4, 2020

rustbot added this to the 1.50.0 milestone Dec 4, 2020

rust-highfive mentioned this pull request Dec 4, 2020

miri no longer builds after rust-lang/rust#79286 #79709

Closed

bors mentioned this pull request Dec 4, 2020

Do not inline finish_grow #78682

Merged

m-ou-se mentioned this pull request Dec 4, 2020

Update to new core::alloc::Allocator interface rust-lang/miri#1639

Merged

TimDiekmann deleted the rename-allocref branch December 4, 2020 23:13

JohnTitor mentioned this pull request Dec 5, 2020

Rename AllocRef to Allocator and (de)alloc to (de)allocate rust-lang/nomicon#248

Merged

TimDiekmann mentioned this pull request Dec 5, 2020

Update to nightly-2020-12-07 TimDiekmann/storages#2

Merged

TimDiekmann mentioned this pull request Dec 7, 2020

Roadmap rust-lang/wg-allocators#48

Open

18 tasks

caelunshun added a commit to caelunshun/hashbrown that referenced this pull request Dec 8, 2020

Account for renaming AllocRef to Allocator on nightly

bbcf93b

The trait's identifier was changed in rust-lang/rust#79286.

caelunshun mentioned this pull request Dec 8, 2020

Account for renaming AllocRef to Allocator on nightly rust-lang/hashbrown#215

Merged

caelunshun added a commit to caelunshun/hashbrown that referenced this pull request Dec 8, 2020

Account for renaming AllocRef to Allocator on nightly

b6daaf0

The trait's identifier was changed in rust-lang/rust#79286.

bors added a commit to rust-lang/hashbrown that referenced this pull request Dec 8, 2020

Auto merge of #215 - caelunshun:rename-allocator, r=Amanieu

acbedaa

Account for renaming AllocRef to Allocator on nightly `AllocRef` was renamed to `Allocator` in rust-lang/rust#79286.

rusty122 added a commit to rusty122/wg-allocators that referenced this pull request Feb 12, 2021

Rename Alloc trait to Allocator in README

7017163

Looks like the trait got renamed in rust-lang/rust#79286

rusty122 mentioned this pull request Feb 12, 2021

Rename Alloc trait to Allocator in README rust-lang/wg-allocators#85

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `AllocRef` to `Allocator` and `(de)alloc` to `(de)allocate` #79286

Rename `AllocRef` to `Allocator` and `(de)alloc` to `(de)allocate` #79286

TimDiekmann commented Nov 22, 2020 •

edited

Loading

rustbot commented Nov 22, 2020

rustbot commented Nov 22, 2020

TimDiekmann commented Nov 22, 2020

bors commented Nov 23, 2020

bors commented Nov 29, 2020

Wodann left a comment

m-ou-se commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

m-ou-se commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

rust-highfive commented Dec 4, 2020

LeSeulArtichaut commented Dec 6, 2020

TimDiekmann commented Dec 6, 2020

Rename AllocRef to Allocator and (de)alloc to (de)allocate #79286

Rename AllocRef to Allocator and (de)alloc to (de)allocate #79286

Conversation

TimDiekmann commented Nov 22, 2020 • edited Loading

rustbot commented Nov 22, 2020

rustbot commented Nov 22, 2020

TimDiekmann commented Nov 22, 2020

bors commented Nov 23, 2020

bors commented Nov 29, 2020

Wodann left a comment

Choose a reason for hiding this comment

m-ou-se commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

m-ou-se commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

bors commented Dec 4, 2020

rust-highfive commented Dec 4, 2020

LeSeulArtichaut commented Dec 6, 2020

TimDiekmann commented Dec 6, 2020

Rename `AllocRef` to `Allocator` and `(de)alloc` to `(de)allocate` #79286

Rename `AllocRef` to `Allocator` and `(de)alloc` to `(de)allocate` #79286

TimDiekmann commented Nov 22, 2020 •

edited

Loading