fix handling the default config for profiler and sanitizers #79155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78354 don't handle the case that user don't add any target-specific config in
[target.*]
ofconfig.toml
:The previes code handle the default config in
Config::prase()
:In this case,
toml.target
don't contain any target, so the above code won't execute. Instead, a defaultTarget
is insert inrust/src/bootstrap/sanity.rs
Lines 162 to 166 in c919f49
The default value for
bool
is false, hence the issue in #79124This fix change the type of
sanitizers
andprofiler
toOption<bool>
, so the default value isNone
, and fallback config is handled inConfig::sanitizers_enabled
andConfig::profiler_enabled
fix #79124
cc @Mark-Simulacrum @richkadel