Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_target: Change os and vendor values to "none" and "unknown" for some targets #78951

Merged
merged 3 commits into from
Nov 14, 2020
Merged

rustc_target: Change os and vendor values to "none" and "unknown" for some targets #78951

merged 3 commits into from
Nov 14, 2020

Commits on Nov 11, 2020

  1. rustc_target: Change os from "unknown" to "none" for bare metal targets 

    x86_64-fortanix-unknown-sgx and wasm32-unknown-unknown still have os == "unknown" because both have libstd
    @petrochenkov
    petrochenkov committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    443b45f View commit details
    Browse the repository at this point in the history

  2. rustc_target: Normalize vendor from "" to "unknown" for all targets 

    Majority of targets use "unknown" vendor and changing it from "unknown" to omitted doesn't make sense.
From the LLVM docs (https://clang.llvm.org/docs/CrossCompilation.html#target-triple):

>Most of the time it can be omitted (and Unknown) will be assumed, which sets the defaults for the specified architecture.
>When a parameter is not important, it can be omitted, or you can choose unknown and the defaults will be used. If you choose a parameter that Clang doesn’t know, like blerg, it’ll ignore and assume unknown
    @petrochenkov
    petrochenkov committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1def24c View commit details
    Browse the repository at this point in the history

  3. rustc_target: Make sure that in-tree targets follow conventions for o… 

    …s and vendor values
    @petrochenkov
    petrochenkov committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    e0a8f22 View commit details
    Browse the repository at this point in the history