-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc examples for iter flatten #78776
Conversation
Thanks! r=me once CI pass |
Ah, I just realized we should hide the imports. |
I just realized we don't have this for the rest of iterators docs, we may need to standardize, most of the docs looks the same but some look different, this one look different too. |
☔ The latest upstream changes (presumably #78874) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author I want to know what the docs team before proceeding. |
Ping from triage @pickfire can you please address the merge conflict? |
@JohnCSimon I am not sure if this pull request is good given that the other parts needed to be changed later when this is merged, I wonder if @GuillaumeGomez think this is good. |
Well, still think the |
True, even though I think it is easier for beginners but it makes it weird to have some parts have this by itself. Closing it. |
r? @GuillaumeGomez