Add fetch_update methods to AtomicBool and AtomicPtr #78637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! Surprising that these didn't exist yet. Looks like they were just forgotten? Can you open a tracking issue for them and add its number in the We can probably kick off the FCP for stabilization on that issue quickly, as this very same function for the other Atomic types is already stable. |
m-ou-se
added
the
T-libs-api
These methods were stabilized for the integer atomics in rust-lang#71843, but the methods were not added for the non-integer atomics `AtomicBool` and `AtomicPtr`.
mystor
force-pushed
the
atomic_ptr_bool
branch
from
669ef35
to
00f32e6
Compare
|
Thanks! @bors r+ |
|
📌 Commit 00f32e6 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 1, 2020
Add fetch_update methods to AtomicBool and AtomicPtr These methods were stabilized for the integer atomics in rust-lang#71843, but the methods were not added for the non-integer atomics `AtomicBool` and `AtomicPtr`.
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#78606 (Clarify handling of final line ending in str::lines()) - rust-lang#78610 (Do not remove tokens before AST json serialization) - rust-lang#78620 (Trivial fixes to bitwise operator documentation) - rust-lang#78627 (Point out that total_cmp is no strict superset of partial comparison) - rust-lang#78637 (Add fetch_update methods to AtomicBool and AtomicPtr) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods were stabilized for the integer atomics in #71843, but the methods were not added for the non-integer atomics
AtomicBoolandAtomicPtr.