Skip to content

add options to use optimized and mangled compiler builtins #78472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2020
Merged

add options to use optimized and mangled compiler builtins #78472

merged 1 commit into from
Nov 15, 2020
+4 −0

Conversation

stlankes
Copy link
Contributor

In principle the compiler builtin features are also offered to alloc and std.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2020
@crlf0710
Copy link
Member

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

I guess this is via -Zbuild-std?

r=me with commits squash

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2020
@stlankes
Copy link
Contributor Author

stlankes commented Nov 15, 2020 •
edited
Loading

Yes, I used it via -Zbuild-std. For instance, the mangled version would help me to build a libos. I would enabled it via https://github.com/hermitcore/rusty-hermit/blob/master/.cargo/config#L3.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 15, 2020

📌 Commit 6de5125 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2020
@bors
Copy link
Collaborator

bors commented Nov 15, 2020

⌛ Testing commit 6de5125 with merge 0468845...

@bors
Copy link
Collaborator

bors commented Nov 15, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0468845 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2020
@bors bors merged commit 0468845 into rust-lang:master Nov 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 15, 2020
@stlankes stlankes deleted the builtins branch November 15, 2020 18:39
@stlankes stlankes mentioned this pull request Nov 16, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#79090 - hermitcore:builtins, r=Mark-Simulacrum
29c8e50 
libary: Forward compiler-builtins "asm"  and "mangled-names" feature

In principle this is a followup of rust-lang#78472. In the previous PR was the support of the test crate missing.

Now users will be able to do:
```
cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-asm
```
and correctly get the assembly implemenations for `memcpy` and friends.
@stlankes stlankes mentioned this pull request Nov 21, 2020
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
7 participants
@stlankes @rust-highfive @crlf0710 @Mark-Simulacrum @bors @cramertj @rustbot