Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexicographical comparison doc #78347

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add lexicographical comparison doc #78347

merged 1 commit into from
Oct 27, 2020

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Oct 25, 2020 •
edited
Loading

close #72255

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2020
@Rustin170506
Copy link
Member Author

Rustin170506 commented Oct 25, 2020 •
edited
Loading

r? @ecstatic-morse

@Rustin170506 Rustin170506 requested a review from jyn514 October 25, 2020 09:47
kennytm
kennytm reviewed Oct 26, 2020
View reviewed changes
library/core/src/cmp.rs Outdated Show resolved Hide resolved
library/core/src/cmp.rs Outdated Show resolved Hide resolved
library/alloc/src/vec.rs Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 force-pushed the rustin-patch-doc branch 2 times, most recently from 10c7134 to cb6921d Compare October 26, 2020 12:29
@Rustin170506 Rustin170506 requested a review from kennytm October 26, 2020 12:33
@jyn514 jyn514 added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 26, 2020
jyn514
jyn514 reviewed Oct 26, 2020
View reviewed changes
library/alloc/src/vec.rs Outdated Show resolved Hide resolved
library/alloc/src/vec.rs Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 requested a review from jyn514 October 26, 2020 14:06
jyn514
jyn514 reviewed Oct 26, 2020
View reviewed changes
library/alloc/src/vec.rs Outdated Show resolved Hide resolved
library/core/src/array/mod.rs Outdated Show resolved Hide resolved
@Rustin170506
Add lexicographical comparison doc
42844ed 
Add links

Fix typo

Use `sequence`

Fix typo

Fix broken link

Fix broken link

Fix broken link

Fix broken links

Fix broken links
@kennytm
Copy link
Member

kennytm commented Oct 26, 2020

r=me when CI pass.

@Rustin170506
Copy link
Member Author

@kennytm All tests passed.

Thanks again for your review. @kennytm @jyn514 ❤️

@kennytm
Copy link
Member

kennytm commented Oct 26, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2020

📌 Commit 42844ed has been approved by kennytm

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 26, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 26, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2020
@bors
Auto merge of rust-lang#78421 - JohnTitor:rollup-bq2d7fo, r=JohnTitor
28f03ac 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#76635 (Add [T]::as_chunks(_mut))
 - rust-lang#77703 (add system-llvm-libunwind config option)
 - rust-lang#78219 (Prefer to use `print_def_path`)
 - rust-lang#78298 (Add test for bad NLL higher-ranked subtype)
 - rust-lang#78332 (Update description for error E0308)
 - rust-lang#78342 (Use check-pass in single-use-lifetime ui tests)
 - rust-lang#78347 (Add lexicographical comparison doc)
 - rust-lang#78348 (Make some functions private that don't have to be public)
 - rust-lang#78349 (Use its own `TypeckResults` to avoid ICE)
 - rust-lang#78375 (Use ? in core/std macros)
 - rust-lang#78377 (Fix typo in debug statement)
 - rust-lang#78388 (Add some regression tests)
 - rust-lang#78394 (fix(docs): typo in BufWriter documentation)
 - rust-lang#78396 (Add compiler support for LLVM's x86_64 ERMSB feature)
 - rust-lang#78405 (Fix typo in lint description)
 - rust-lang#78412 (Improve formatting of hash collections docs)

Failed merges:

r? `@ghost`
@bors bors merged commit 727e93d into rust-lang:master Oct 27, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@kennytm kennytm Awaiting requested review from kennytm

Assignees

@kennytm kennytm

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

No definition of lexicographic order in docs for Iterator::cmp*
6 participants
@Rustin170506 @rust-highfive @kennytm @bors @jyn514 @rustbot