-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to rustdoc book in rustdoc help popup #78103
Conversation
Some changes occurred in HTML/CSS/JS. Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with or without nit :) This looks great!
2322486
to
880d644
Compare
@bors r+ rollup |
📌 Commit 880d644 has been approved by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but the keyboard buttons in the dark theme looks ugly to me.
But should we really make it javascript only? Maybe html can display it by default when <noscript>
in the bottom, but that's another issue.
@pickfire: It's completely beyond the scope of this PR. Also, if you don't have JS enabled, this popup cannot be displayed (and that's the whole point since it's mostly about search after all, which only works with JS 😆 ). |
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#77877 (Use `try{}` in `try_fold` to decouple iterators in the library from `Try` details) - rust-lang#78089 (Fix issue with specifying generic arguments for primitive types) - rust-lang#78099 (Add missing punctuation) - rust-lang#78103 (Add link to rustdoc book in rustdoc help popup) Failed merges: r? `@ghost`
Part of #75520.
It looks like this:
r? @jyn514