Remove unused code #77739

est31 · 2020-10-09T09:27:06Z

Rustc has a builtin lint for detecting unused code inside a crate, but when an item is marked pub, the code, even if unused inside the entire workspace, is never marked as such. Therefore, I've built warnalyzer to detect unused items in a cross-crate setting.

Closes est31/warnalyzer#2

rust-highfive · 2020-10-09T09:27:10Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

est31 · 2020-10-09T09:31:49Z

See also #77740

est31 · 2020-10-09T11:11:20Z

Network hickup.

@bors retry

est31 · 2020-10-09T11:30:51Z

Nevermind, wrong PR. Meant #77690 instead.

petrochenkov · 2020-10-09T20:57:40Z

r=me on everything in rustc_(ast,errors,expand,hir,hir_pretty,lint,metadata,parse,session,span).

I'd suggest to make sure this doesn't break clippy/rls/etc though, by doing textual search on the repo (together with all the submodules) for the removed entities.

est31 · 2020-10-10T06:20:56Z

I'd suggest to make sure this doesn't break clippy/rls/etc though, by doing textual search on the repo (together with all the submodules) for the removed entities.

I made a textual search for most things, yes, already because warnalyzer has tons of false positives. As a result, some things I didn't include in this PR. Some names are highly non-unique though, so I didn't verify it with a search for all of them.

To be really sure, I just enabled extended = true in config.toml and did an x.py build --stage 1 to compile all the tools. It all works fine.

compiler/rustc_middle/src/mir/interpret/value.rs

varkor

Most of the other changes look fine to me, though I would prefer a second pair of eyes on the rustc_middle/src/mir changes just to double-check.
cc @oli-obk @RalfJung

compiler/rustc_middle/src/ty/fold.rs

compiler/rustc_mir/src/interpret/operand.rs

RalfJung · 2020-10-10T14:37:38Z

Most of the other changes look fine to me, though I would prefer a second pair of eyes on the rustc_middle/src/mir changes just to double-check.

I checked the changes in interpret; I cannot really comment on the wider MIR module. Not sure if Oli has plans for those const convenience methods that are being removed here, or if they are old cruft.

varkor · 2020-10-12T13:47:06Z

I think this looks good to merge once the Direction enum has been removed!

bors · 2020-10-12T21:33:50Z

☔ The latest upstream changes (presumably #77867) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

bors · 2020-10-14T00:54:24Z

☔ The latest upstream changes (presumably #77917) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

est31 · 2020-10-14T02:15:15Z

@varkor it's ready for review.

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

varkor · 2020-10-14T18:29:10Z

compiler/rustc_hir/src/hir.rs

@@ -467,23 +462,6 @@ impl Generics<'hir> {
        }
    }

-    pub fn own_counts(&self) -> GenericParamCount {


Ah, I'm glad to see this go.

varkor · 2020-10-14T18:30:06Z

@bors r=petrochenkov,varkor

bors · 2020-10-14T18:30:08Z

📌 Commit 215cd36 has been approved by petrochenkov,varkor

bors · 2020-10-14T18:30:10Z

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Rollup of 9 pull requests Successful merges: - rust-lang#77570 (Allow ascii whitespace char for doc aliases ) - rust-lang#77739 (Remove unused code) - rust-lang#77753 (Check html comments) - rust-lang#77879 (Provide better documentation and help messages for x.py setup) - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) - rust-lang#77934 (Document -Z codegen-backend in the unstable book) - rust-lang#77936 (Remove needless alloc_slice) - rust-lang#77946 (Validate references to source scopes) - rust-lang#77951 (Update books) Failed merges: r? `@ghost`

Remove (lots of) dead code Builds on - [ ] rust-lang#83161 - [x] rust-lang#83230 - [x] rust-lang#83197. Found with https://github.com/est31/warnalyzer. See rust-lang#77739 for a similar change in the past. Dubious changes: - Maybe some of the dead code in rustc_data_structures should be kept, in case someone wants to use it in the future? TODO: - [ ] check if any of the comments on the deleted code should be kept. - [x] update the compiler documentation; right now it fails to build - [x] finish moving `cfg(test)` changes into rust-lang#83197 cc `@est31`

Remove (lots of) dead code Builds on - [ ] rust-lang/rust#83161 - [x] rust-lang/rust#83230 - [x] rust-lang/rust#83197. Found with https://github.com/est31/warnalyzer. See rust-lang/rust#77739 for a similar change in the past. Dubious changes: - Maybe some of the dead code in rustc_data_structures should be kept, in case someone wants to use it in the future? TODO: - [ ] check if any of the comments on the deleted code should be kept. - [x] update the compiler documentation; right now it fails to build - [x] finish moving `cfg(test)` changes into rust-lang/rust#83197 cc `@est31`

rust-highfive assigned varkor Oct 9, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2020

est31 mentioned this pull request Oct 9, 2020

types_escaping_snapshot is unused #77740

Closed

est31 force-pushed the remove_unused_code branch 3 times, most recently from 52512cd to ed0d9fc Compare October 9, 2020 10:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2020

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2020

varkor reviewed Oct 10, 2020

View reviewed changes

compiler/rustc_middle/src/mir/interpret/value.rs Show resolved Hide resolved

varkor reviewed Oct 10, 2020

View reviewed changes

compiler/rustc_middle/src/ty/fold.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 10, 2020

View reviewed changes

compiler/rustc_mir/src/interpret/operand.rs Outdated Show resolved Hide resolved

est31 force-pushed the remove_unused_code branch from ed0d9fc to 439f2d6 Compare October 10, 2020 14:44

est31 force-pushed the remove_unused_code branch from 439f2d6 to fc30e7e Compare October 13, 2020 05:17

est31 added 5 commits October 14, 2020 04:14

Remove unused code from rustc_middle

d7791f4

Remove unused code from rustc_ast

49d4a75

Remove unused code from rustc_codegen_*

feaac59

Remove unused code from rustc_hir

6897619

Remove unused code from rustc_infer

9ed2177

est31 added 3 commits October 14, 2020 04:14

Remove unused code from rustc_query_system

338fad2

Remove unused code from rustc_span

58b3923

Remove unused code from remaining compiler crates

215cd36

est31 force-pushed the remove_unused_code branch from fc30e7e to 215cd36 Compare October 14, 2020 02:14

varkor reviewed Oct 14, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020

JohnTitor mentioned this pull request Oct 14, 2020

Rollup of 9 pull requests #77954

Merged

bors merged commit 022d207 into rust-lang:master Oct 15, 2020

rustbot added this to the 1.49.0 milestone Oct 15, 2020

euclio mentioned this pull request Oct 15, 2020

ensure arguments are included in count mismatch span #75023

Merged

est31 mentioned this pull request Oct 16, 2020

Try on rustc est31/warnalyzer#2

Closed

JohnTitor mentioned this pull request Mar 14, 2021

Remove unused opt_local_def_id_to_hir_id function #83108

Merged

jyn514 mentioned this pull request Mar 16, 2021

Remove (lots of) dead code #83185

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused code #77739

Remove unused code #77739

est31 commented Oct 9, 2020

rust-highfive commented Oct 9, 2020

est31 commented Oct 9, 2020

est31 commented Oct 9, 2020

est31 commented Oct 9, 2020

petrochenkov commented Oct 9, 2020

est31 commented Oct 10, 2020 •

edited

Loading

varkor left a comment

RalfJung commented Oct 10, 2020

varkor commented Oct 12, 2020

bors commented Oct 12, 2020

bors commented Oct 14, 2020

est31 commented Oct 14, 2020

varkor Oct 14, 2020

varkor commented Oct 14, 2020

bors commented Oct 14, 2020

bors commented Oct 14, 2020

Remove unused code #77739

Remove unused code #77739

Conversation

est31 commented Oct 9, 2020

rust-highfive commented Oct 9, 2020

est31 commented Oct 9, 2020

est31 commented Oct 9, 2020

est31 commented Oct 9, 2020

petrochenkov commented Oct 9, 2020

est31 commented Oct 10, 2020 • edited Loading

varkor left a comment

Choose a reason for hiding this comment

RalfJung commented Oct 10, 2020

varkor commented Oct 12, 2020

bors commented Oct 12, 2020

bors commented Oct 14, 2020

est31 commented Oct 14, 2020

varkor Oct 14, 2020

Choose a reason for hiding this comment

varkor commented Oct 14, 2020

bors commented Oct 14, 2020

bors commented Oct 14, 2020

est31 commented Oct 10, 2020 •

edited

Loading