Add -Z codegen-backend dylib to deps #77565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the codegen-backend dylib changes, the program should be rebuilt.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This was referenced Oct 5, 2020
|
I was waiting for @Mark-Simulacrum to have a look, but this seems correct in the abstract. @bors r+ rollup |
|
📌 Commit ba22fbe has been approved by |
bors
added
S-waiting-on-bors
|
This seems good, I think I missed or forgot about the initial ping. I will see PRs assigned to me so please r? me in the future. |
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the codegen-backend dylib changes, the program should be rebuilt.
Unfortunately I was unable to test this works locally due to running into a TLS issue when running the custom backend,
thread 'rustc' panicked at 'no ImplicitCtxt stored in tls', compiler/rustc_middle/src/ty/context.rs:1750:54, which seems similar to #62717 but has a completely different cause and backtrace.@eddyb said to ping @Mark-Simulacrum about what they think about this, so, ping!