Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create E0777 error code for invalid argument in derive #77419

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Create E0777 error code for invalid argument in derive #77419

merged 3 commits into from
Oct 4, 2020

Conversation

GuillaumeGomez
Copy link
Member

The second commit is to fix a nit reported by @jyn514 here.

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020
jyn514
jyn514 reviewed Oct 1, 2020
View reviewed changes
compiler/rustc_error_codes/src/error_codes.rs Outdated Show resolved Hide resolved
compiler/rustc_error_codes/src/error_codes/E0777.md Outdated Show resolved Hide resolved
compiler/rustc_expand/src/proc_macro.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints A-error-codes Area: Explanation of an error code (--explain) A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 1, 2020
@GuillaumeGomez
Copy link
Member Author

@jyn514 I added what you suggested. ;)

jyn514
jyn514 approved these changes Oct 2, 2020
View reviewed changes
compiler/rustc_expand/src/proc_macro.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

Done as well.

@jyn514
Copy link
Member

jyn514 commented Oct 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 3, 2020

📌 Commit d1d94ba has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2020
@bors
Auto merge of rust-lang#77517 - JohnTitor:rollup-msbd49e, r=JohnTitor
2251766 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#75143 (Use `tracing` spans to trace the entire MIR interp stack)
 - rust-lang#75699 (Uplift drop-bounds lint from clippy)
 - rust-lang#76768 (Test and reject out-of-bounds shuffle vectors)
 - rust-lang#77190 (updated p! macro to accept literals)
 - rust-lang#77388 (Add some regression tests)
 - rust-lang#77419 (Create E0777 error code for invalid argument in derive)
 - rust-lang#77447 (BTreeMap: document DrainFilterInner better)
 - rust-lang#77468 (Fix test name)
 - rust-lang#77469 (Improve rustdoc error for failed intra-doc link resolution)
 - rust-lang#77473 (Make --all-targets in x.py check opt-in)
 - rust-lang#77508 (Fix capitalization in blog post name)

Failed merges:

r? `@ghost`
@bors bors merged commit 830d1a0 into rust-lang:master Oct 4, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 4, 2020
@GuillaumeGomez GuillaumeGomez deleted the create-e0777 branch October 4, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees

@eddyb eddyb

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-error-codes Area: Explanation of an error code (--explain) A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @jyn514 @bors @eddyb @rustbot