Add missing examples for Fd traits #77182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
You linked the wrong PR again :P |
jyn514
reviewed
Sep 25, 2020
library/std/src/sys/unix/ext/io.rs
Outdated
| /// | ||
| /// fn main() -> std::io::Result<()> { | ||
| /// let mut f = File::open("foo.txt")?; | ||
| /// let raw_fd = f.as_raw_fd(); |
There was a problem hiding this comment.
Suggested change
| /// let raw_fd = f.as_raw_fd(); | |
| /// let raw_fd: RawFd = f.as_raw_fd(); |
|
Computers are my nemesis... |
jyn514
added
A-docs
|
r? @jyn514 |
the8472
reviewed
Sep 25, 2020
pickfire
reviewed
Sep 25, 2020
GuillaumeGomez
force-pushed
the
missing-examples-fd-traits
branch
from
4471d15 to
a0485af
Compare
GuillaumeGomez
force-pushed
the
missing-examples-fd-traits
branch
from
a0485af to
980e1ff
Compare
|
Updated! |
pickfire
reviewed
Sep 26, 2020
|
Updated! Let's how it works without a function to wrap. :) |
|
@bors: r=pickfire rollup |
|
📌 Commit d6b838b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 2, 2020
…as-schievink Rollup of 8 pull requests Successful merges: - rust-lang#75377 (Fix Debug implementations of some of the HashMap and BTreeMap iterator types) - rust-lang#76107 (Write manifest for MAJOR.MINOR channel to enable rustup convenience) - rust-lang#76745 (Move Wrapping<T> ui tests into library) - rust-lang#77182 (Add missing examples for Fd traits) - rust-lang#77251 (Bypass const_item_mutation if const's type has Drop impl) - rust-lang#77264 (Only use LOCAL_{STDOUT,STDERR} when set_{print/panic} is used. ) - rust-lang#77421 (Revert "resolve: Avoid "self-confirming" import resolutions in one more case") - rust-lang#77452 (Permit ty::Bool in const generics for v0 mangling) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what happened here... This is a reopening of #77142
r? @Dylan-DPC