Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notrust in rustc_middle #76161

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Remove notrust in rustc_middle #76161

merged 1 commit into from
Sep 1, 2020

Conversation

pickfire
Copy link
Contributor

Fix #19599

This confuse people, no trust or not rust?
Or not rust no trust? Only trust rust ^^

Superseeds #76063
r? @matklad

@pickfire
Remove notrust in rustc_middle
85a400d 
Fix rust-lang#19599

This confuse people, no trust or not rust?
Or not rust no trust? Only trust rust ^^
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2020
@tesuji
Copy link
Contributor

tesuji commented Aug 31, 2020 •
edited
Loading

@pickfire , Could you remove the r? line from PR description ? Otherwise the reviewer will be pinged when the PR is rollupped or bor try, or even after this is merged, the reviewer will be pinged by forks pulling the changes on github.

@matklad
Copy link
Member

matklad commented Aug 31, 2020

Otherwise the reviewer will be pinged when the PR is rollup or bor try?

@lzutao do you know if we have an issue opened on the bors side to fix it? Seems relatively straightforward to regex-replace PR description.

@matklad
Copy link
Member

matklad commented Aug 31, 2020

r=me with PR description edited

@bors delegate

@matklad
Copy link
Member

matklad commented Aug 31, 2020

@bors delegate=pickfire

@bors
Copy link
Contributor

bors commented Aug 31, 2020

✌️ @pickfire can now approve this pull request

@tesuji tesuji mentioned this pull request Aug 31, 2020
Closed
@pickfire
Copy link
Contributor Author

pickfire commented Aug 31, 2020 •
edited
Loading

@lzutao r? is not in the commit message, it's the pull request message. By the way, I ping him because he was the one that previously approved the previous pull request.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 31, 2020

📌 Commit 85a400d has been approved by pickfire

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2020
@pickfire
Copy link
Contributor Author

Wow, nice.

@bors
Copy link
Contributor

bors commented Aug 31, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 31, 2020

📌 Commit 85a400d has been approved by pickfire

@tesuji
Copy link
Contributor

tesuji commented Aug 31, 2020 •
edited
Loading

You should use r=matklad.

r? is not in the commit message, it's the pull request message.

Bors always use the PR description as message of merge commit.

I ping him because he was the one that previously approved the previous pull request.

yeah, removing the mentions shouldn't remove the ping to the person. I maybe wrong. But highfive also do the job.

@pickfire
Copy link
Contributor Author

Ah, I didn't know about r=matklad yet.

@tmandry tmandry mentioned this pull request Sep 1, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2020
@bors
Auto merge of rust-lang#76186 - tmandry:rollup-49nliiy, r=tmandry
445f34b 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#75945 (Use `env::func()`, not 'the function env::func' in docs for std::env)
 - rust-lang#76002 (Fix `-Z instrument-coverage` on MSVC)
 - rust-lang#76003 (Adds two source span utility functions used in source-based coverage)
 - rust-lang#76059 (Clean up E0764)
 - rust-lang#76103 (Clean up E0769)
 - rust-lang#76139 (Make `cow_is_borrowed` methods const)
 - rust-lang#76154 (Fix rustdoc strings indentation)
 - rust-lang#76161 (Remove notrust in rustc_middle)
 - rust-lang#76163 (README: Adjust Linux and macOS support platform and architecture)
 - rust-lang#76166 (Make `StringReader` private)
 - rust-lang#76172 (Revert rust-lang#75463)
 - rust-lang#76178 (Update expect-test to 1.0)

Failed merges:

r? @ghost
@bors bors merged commit 9df193b into rust-lang:master Sep 1, 2020
@pickfire pickfire deleted the patch-3 branch September 1, 2020 15:00
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matklad matklad

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Remove usage of 'notrust' in the docs
6 participants
@pickfire @tesuji @matklad @bors @cuviper @rust-highfive