GH-66816: Remove disable attr before return #76052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing --disable-per-crate-search removes the create search inputs so moved code around so that the search input is enabled first before the function returns
|
Some changes occurred in HTML/CSS/JS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -2740,6 +2740,10 @@ function defocusSearchBar() { | |||
| } | |||
|
|
|||
| window.addSearchOptions = function(crates) { | |||
| if (search_input) { | |||
There was a problem hiding this comment.
Even if very unlikely, I don't like the idea to enable the search input if the other processing isn't done. So instead of just moving this call here, I suggest to put it inside a function and then call this function in the if (!elem) { block and at the end of the addSearchOptions. What do you think?
There was a problem hiding this comment.
Thanks, yes I didn't think about the processing angle, made the change now.
|
Thanks! @bors: r+ rollup |
|
📌 Commit eb2bb99 has been approved by |
bors
added
S-waiting-on-bors
matklad
added a commit
to matklad/rust
that referenced
this pull request
Aug 31, 2020
…ribute_before_return, r=GuillaumeGomez rust-langGH-66816: Remove disable attr before return Passing --disable-per-crate-search removes the create search inputs so moved code around so that the search input is enabled first before the function returns. Fixes rust-lang#66816
This was referenced Aug 31, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#75969 (Switch to intra-doc links in core/src/{convert,iter}/mod.rs) - rust-lang#76023 (Liballoc extend use intra doc link) - rust-lang#76033 (Add missing hyphen) - rust-lang#76052 (rust-langGH-66816: Remove disable attr before return) - rust-lang#76055 (Keep doc standard for Vec DrainFilter) - rust-lang#76058 (Use assertions on Vec doc) - rust-lang#76069 (Use explicit intra-doc link in path for Vec resize) - rust-lang#76117 (Update README.md) - rust-lang#76134 (Update MinGW instructions to include ninja) Failed merges: r? @ghost
jyn514
added a commit
to jyn514/docs.rs
that referenced
this pull request
Aug 31, 2020
|
Thank you so much for this! I'd nearly forgotten it was broken 😅 |
jyn514
added
the
T-rustdoc
jyn514
added a commit
to jyn514/docs.rs
that referenced
this pull request
Sep 5, 2020
jyn514
added a commit
to rust-lang/docs.rs
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing --disable-per-crate-search removes the create search inputs so moved code around so that the search input is enabled
first before the function returns.
Fixes #66816