Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cancel-outdated-builds after fully setting up the env #76018

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

pietroalbini
Copy link
Member

This PR fixes #75995 not working as expected.

Due to GitHub Actions limitations the environment variables set in the build matrix definition are not added by the GHA runner, but by the setup-environment.sh script. Before this PR the cancel-outdated-builds action was started before that script, so it was never able to detect the "suppression" variable added in #75995. This PR reorders the jobs to make sure setup-environment.sh runs before the action.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2020
@pietroalbini
Copy link
Member Author

@bors p=100 rollup=never

I'll babysit landing this PR, since the only way to check if this works (without messing up half our CI configuration) is to see if it indeed works when doing an auto build :)

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 28, 2020

📌 Commit 19d072f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2020
@bors
Copy link
Contributor

bors commented Aug 28, 2020

⌛ Testing commit 19d072f with merge c10ce7a53cb149c4c53462c24b1c18093fc1ac87...

@pietroalbini
Copy link
Member Author

It's working!

2020-08-28--14-29-28

@bors
Copy link
Contributor

bors commented Aug 28, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2020
@pietroalbini
Copy link
Member Author

What. @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2020
@bors
Copy link
Contributor

bors commented Aug 28, 2020

⌛ Testing commit 19d072f with merge abb98ca...

@jyn514
Copy link
Member

jyn514 commented Aug 28, 2020

@pietroalbini I ran into the same issue in #75916 (comment)

@jyn514 jyn514 added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Aug 28, 2020
@bors
Copy link
Contributor

bors commented Aug 28, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing abb98ca to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2020
@bors bors merged commit abb98ca into rust-lang:master Aug 28, 2020
@pietroalbini pietroalbini deleted the ci-left-fallible-finish-2 branch December 23, 2020 23:00
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants