-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve: Do not put nonexistent crate meta
into prelude
#75802
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts. |
Could someone from lang team to look at this? |
This seems reasonable. Our policy changed since the 2018 edition, and we no longer reserve keyword-like things until there's a concrete proposal. There's still support in the @rust-lang/lang team for using the name Given that: @rfcbot merge We'd welcome someone submitting concrete patches adding sysroot names under a built-in crate |
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
As per @pnkfelix's request on Discord, the |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
r=me once rebased |
@bors r=nikomatsakis rollup |
📌 Commit 3522add has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#75802 (resolve: Do not put nonexistent crate `meta` into prelude) - rust-lang#76607 (Modify executable checking to be more universal) - rust-lang#77851 (BTreeMap: refactor Entry out of map.rs into its own file) - rust-lang#78043 (Fix grammar in note for orphan-rule error [E0210]) - rust-lang#78048 (Suggest correct place to add `self` parameter when inside closure) - rust-lang#78050 (Small CSS cleanup) - rust-lang#78059 (Set `MDBOOK_OUTPUT__HTML__INPUT_404` on linkchecker) Failed merges: r? `@ghost`
Before the 2018 edition release there was some vague suggestion about adding a crate named
meta
to the standard distribution.On this basis the name
meta
was "partially reserved" by puttingmeta
into extern prelude (this means importing something namedmeta
will result in an ambiguity error, for example).This only caused confusion so far, and two years later there are no specific plans to add such crate.
If some standard crate (named
meta
or not) is added in the future, then cargo will hopefully already have ability to put it into extern prelude explicitly throughCargo.toml
.Otherwise, it could be added to extern prelude by the compiler at edition boundary.
Closes #73948