Replace Memoryblock with NonNull<[u8]>
#75152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 93d9832 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 93d9832 with merge 8d188d8fa7066ffe69511440d73ea6099eaefaf4... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The failure is spurious: rust-lang/cargo#8517 |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 5, 2020
…nieu Replace `Memoryblock` with `NonNull<[u8]>` Closes rust-lang/wg-allocators#61 r? @Amanieu
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#75139 (Remove log alias from librustdoc) - rust-lang#75140 (Clean up E0745) - rust-lang#75149 (Correct a typo in interpret/memory.rs) - rust-lang#75152 (Replace `Memoryblock` with `NonNull<[u8]>`) - rust-lang#75168 (Update books) Failed merges: r? @ghost
4 tasks
bors bot
added a commit
to softdevteam/libgc
that referenced
this pull request
Aug 7, 2020
19: Update after recent rust-nightly changes. r=jacob-hughes a=ltratt There are two PRs which affect us: rust-lang/rust#74850 rust-lang/rust#75152 Henceforth, we should probably be keeping a close eye on and contributing to: https://github.com/rust-lang/wg-allocators/issues Co-authored-by: Laurence Tratt <laurie@tratt.net>
bors bot
added a commit
to softdevteam/libgc
that referenced
this pull request
Aug 10, 2020
19: Update after recent rust-nightly changes. r=vext01 a=ltratt There are two PRs which affect us: rust-lang/rust#74850 rust-lang/rust#75152 Henceforth, we should probably be keeping a close eye on and contributing to: https://github.com/rust-lang/wg-allocators/issues Co-authored-by: Laurence Tratt <laurie@tratt.net>
|
This appears to have been a slight regression, though very slight so hard to be certain: https://perf.rust-lang.org/compare.html?start=32d14eba47ee8bb0b5edb04bcf652517f81c4cf5&end=119d2a1a98fe87d4ae6cabf12134a0ef2fb95851. @Amanieu, do you think it's plausible this is slowing something down? It looks pretty innocuous to me... |
|
Perhaps it's because we call |
|
Hm yeah I don't really know that we'll be able to narrow it down, the cachegrind diff doesn't look obviously indicative of anything on deeply-nested-debug at least. My guess is that deeply-nested-debug is actually just nondeterministic or something, because this PR (or anything in the rollup) shouldn't have caused query count differences. |
JohnTitor
added a commit
to JohnTitor/nomicon
that referenced
this pull request
Aug 18, 2020
Mark-Simulacrum
added a commit
to rust-lang/nomicon
that referenced
this pull request
Aug 19, 2020
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2020
Update books ## nomicon 2 commits in bfe1ab96d717d1dda50e499b360f2e2f57e1750a..25854752549d44d76fbd7650e17cb4f167a0b8fb 2020-06-05 13:19:42 -0400 to 2020-08-19 16:41:48 -0400 - Follow-up of rust-lang#75152 (rust-lang/nomicon#235) - Follow-up for rust-lang#74850 (rust-lang/nomicon#233) ## reference 7 commits in c9b2736a059469043177e1e4ed41a55d7c63ac28..1b6c4b0afab97c0230433466c97167bbbe8445f6 2020-08-03 03:34:03 -0700 to 2020-08-18 17:04:28 -0700 - Some constant/static updates. (rust-lang/reference#867) - Add casting rules from function items to other types (rust-lang/reference#878) - Apply joshtriplett's suggestion - Add note clarifying 16-bit support. - Document min pointer width. - Update to `dyn Trait` syntax in a couple places (rust-lang/reference#875) - mention that `#[track_caller]` on `fn main` is forbidden (rust-lang/reference#872) ## book 2 commits in 363293c1c5ce9e84ea3935a5e29ce8624801208a..c0a6a61b8205da14ac955425f74258ffd8ee065d 2020-08-03 15:56:30 -0500 to 2020-08-14 14:21:49 -0500 - Correct listing 11-10: Take tests module out of main function. (rust-lang/book#2427) - Update link to russian translation (rust-lang/book#2423) ## rust-by-example 5 commits in 2e9271981adc32613365810f3428334c07095215..80a10e22140e28392b99d24ed02f4c6d8cb770a0 2020-07-27 13:39:16 -0500 to 2020-08-08 09:56:46 -0300 - Add tuple `..` operator example (rust-lang/rust-by-example#1368) - Clarify wording (rust-lang/rust-by-example#1366) - Include arc (rust-lang/rust-by-example#1365) - Modify supertraits sample code (rust-lang/rust-by-example#1361) - Remove mention of `try!` in `Display` example (rust-lang/rust-by-example#1357) ## embedded-book 3 commits in b5256448a2a4c1bec68b93c0847066f92f2ff5a9..0cd2ca116274b915924c3a7e07c1e046b6f19b77 2020-07-24 23:09:29 +0000 to 2020-08-19 10:33:15 +0000 - Ignore unused argument in closure (rust-embedded/book#261) - Fix broken sentence (rust-embedded/book#260) - Add additional command to try when verifying installation. (rust-embedded/book#259)
jacob-hughes
added a commit
to jacob-hughes/alloy
that referenced
this pull request
Sep 8, 2020
There are two PRs which affect us:
rust-lang#74850
rust-lang#75152
Henceforth, we should probably be keeping a close eye on and contributing to:
https://github.com/rust-lang/wg-allocators/issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rust-lang/wg-allocators#61
r? @Amanieu