Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbid #[track_caller] on main #75130

Merged
merged 2 commits into from
Aug 5, 2020
Merged

forbid #[track_caller] on main #75130

merged 2 commits into from
Aug 5, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Aug 4, 2020

fixes #75125

cc @anp

@rust-highfive
Copy link
Collaborator

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@lcnr lcnr added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 4, 2020
@ecstatic-morse
Copy link
Contributor

r=me with the error message tweaked.

@lcnr
Copy link
Contributor Author

lcnr commented Aug 4, 2020

@bors r=ecstatic-morse

@bors
Copy link
Contributor

bors commented Aug 4, 2020

📌 Commit 1af7572ac25b68b4f475246166162246adc78089 has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit 1af7572ac25b68b4f475246166162246adc78089 with merge 8cde14e50d17ffe51b486a20f0f1f91eb236ab07...

@ecstatic-morse
Copy link
Contributor

@bors r- The stdarch bump got added back in the last commit. git add -p is your friend 😄.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2020
@lcnr
Copy link
Contributor Author

lcnr commented Aug 4, 2020

come on 😢 I blame vs code here

Thanks for noticing @bors r=ecstatic-morse

I should look into automatically preventing this, considering how often this has happend to me

@bors
Copy link
Contributor

bors commented Aug 4, 2020

📌 Commit 9127e27 has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2020
@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit 9127e27 with merge 30e5c68e6961f49f14deb5e53d3d3a5d8e500842...

@bors
Copy link
Contributor

bors commented Aug 4, 2020

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 4, 2020
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@rust-log-analyzer
Copy link
Collaborator

The job i686-gnu-nopt of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@JohnTitor
Copy link
Member

The failure is spurious: rust-lang/cargo#8517
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 5, 2020
@Manishearth
Rollup merge of rust-lang#75130 - lcnr:array_chunks, r=ecstatic-morse
16226c1 
forbid `#[track_caller]` on main

fixes rust-lang#75125

cc @anp
@Manishearth Manishearth mentioned this pull request Aug 5, 2020
Closed
@bors
Copy link
Contributor

bors commented Aug 5, 2020

⌛ Testing commit 9127e27 with merge 32d14eb...

@bors
Copy link
Contributor

bors commented Aug 5, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 32d14eb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2020
@bors bors merged commit 32d14eb into rust-lang:master Aug 5, 2020
@lcnr lcnr deleted the array_chunks branch August 5, 2020 06:27
@ehuss
Copy link
Contributor

ehuss commented Aug 5, 2020

@lcnr Would you mind adding a small note to https://github.com/rust-lang/reference/blob/master/src/attributes/codegen.md#the-track_caller-attribute about this restriction?

@lcnr
Copy link
Contributor Author

lcnr commented Aug 5, 2020

not exactly sure how to best formulate this but opened rust-lang/reference#872 for now

@spastorino
Copy link
Member

Adding missing T-compiler label so this is picked up by prioritization automation bot and placed into the compiler team meeting agenda.

@spastorino spastorino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 5, 2020
@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 6, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 7, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 7, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
@bors
Auto merge of rust-lang#75261 - Mark-Simulacrum:beta-next, r=Mark-Sim…
63ca028 
…ulacrum

[beta] backports

* Forbid non-derefable types explicitly in unsizing casts rust-lang#75136
* forbid `#[track_caller]` on main rust-lang#75130
* Fix #[track_caller] shims for trait objects. rust-lang#74784
* rustc_target: Add a target spec option for disabling `--eh-frame-hdr` rust-lang#74631
* Disable Azure Pipelines except for macOS rust-lang#74620
* Upload builds from GHA instead of Azure Pipelines rust-lang#74565
* Add the aarch64-apple-darwin target rust-lang#74541
* Use `ReEmpty(U0)` as the implicit region bound in typeck rust-lang#74509
* rustbuild: drop tool::should_install rust-lang#74457
* lint: use `transparent_newtype_field` to avoid ICE rust-lang#74340
* Don't panic if the lhs of a div by zero is not statically known rust-lang#74221
* improper_ctypes_definitions: allow `Box` rust-lang#74448
* typeck: check for infer before type impls trait rust-lang#73965
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecstatic-morse ecstatic-morse ecstatic-morse left review comments

@anp anp anp approved these changes

Assignees

@ecstatic-morse ecstatic-morse

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Program crashes with #[track_caller] applied to main()