Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Investigate mark_used(attr) #74952

Closed
wants to merge 2 commits into from
Closed

[WIP] Investigate mark_used(attr) #74952

wants to merge 2 commits into from

Conversation

petrochenkov
Copy link
Contributor

r? @ghost

@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 30, 2020

⌛ Trying commit 5a7416d56af30cb913f0efcfc4fe7a8c950e934c with merge e1489337a11ba38720eba65fe1dd549de224ab40...

@petrochenkov petrochenkov mentioned this pull request Jul 30, 2020
Merged
@bors
Copy link
Contributor

bors commented Jul 30, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: e1489337a11ba38720eba65fe1dd549de224ab40 (e1489337a11ba38720eba65fe1dd549de224ab40)

@rust-timer
Copy link
Collaborator

Queued e1489337a11ba38720eba65fe1dd549de224ab40 with parent 6b09c37, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e1489337a11ba38720eba65fe1dd549de224ab40): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 31, 2020
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 1, 2020

⌛ Trying commit ecf5823911045b2beff2ea829d070fcfb205b734 with merge b514752e6643f54cbcf1fc1685e0fe4c4e6e3c4d...

@bors
Copy link
Contributor

bors commented Aug 1, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: b514752e6643f54cbcf1fc1685e0fe4c4e6e3c4d (b514752e6643f54cbcf1fc1685e0fe4c4e6e3c4d)

@rust-timer
Copy link
Collaborator

Queued b514752e6643f54cbcf1fc1685e0fe4c4e6e3c4d with parent b5eae9c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b514752e6643f54cbcf1fc1685e0fe4c4e6e3c4d): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@petrochenkov
rustc_ast: (Nested)MetaItem::check_name -> has_name
0efc743 
For consistency with `Attribute::has_name` which doesn't mark the attribute as used either.

Replace all uses of `check_name` with `has_name` outside of rustc
@petrochenkov
WIP
6b870d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrochenkov @rust-timer @bors