fixed error reporting for mismatched traits #74698
Conversation
mismatched traits were previously referred to as types
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Neat solution! Could we add a test or two exercising the new behavior? It can be just including the case from the original report. |
|
r? @estebank |
|
Thanks! Just added a test under E0308-2.rs |
|
@bors r+ |
|
📌 Commit b75ed4f has been approved by |
bors
added
S-waiting-on-bors
…=estebank fixed error reporting for mismatched traits mismatched traits were previously referred to as types closes rust-lang#72217
…arth Rollup of 8 pull requests Successful merges: - rust-lang#72954 (revise RwLock for HermitCore) - rust-lang#74367 (Rearrange the pipeline of `pow` to gain efficiency) - rust-lang#74491 (Optimize away BitAnd and BitOr when possible) - rust-lang#74639 (Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x) - rust-lang#74661 (Refactor `region_name`: add `RegionNameHighlight`) - rust-lang#74692 (delay_span_bug instead of silent ignore) - rust-lang#74698 (fixed error reporting for mismatched traits) - rust-lang#74715 (Add a system for creating diffs across multiple mir optimizations.) Failed merges: r? @ghost
mismatched traits were previously referred to as types
closes #72217