Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the documentation for Vec::drain #74652

Merged
merged 3 commits into from
Jul 25, 2020
Merged

Improve the documentation for Vec::drain #74652

merged 3 commits into from
Jul 25, 2020

Conversation

poliorcetics
Copy link
Contributor

Fixes #73844.

@rusbot modify labels: A-collections, C-enhancement, T-doc, T-libs

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2020
jyn514
jyn514 reviewed Jul 23, 2020
View reviewed changes
src/liballoc/vec.rs Outdated Show resolved Hide resolved
jyn514
jyn514 reviewed Jul 23, 2020
View reviewed changes
src/liballoc/vec.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 added A-collections Area: std::collections. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2020
@jyn514
Copy link
Member

jyn514 commented Jul 24, 2020

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Jul 24, 2020

📌 Commit 654c180 has been approved by jyn514

@bors
Copy link
Contributor

bors commented Jul 24, 2020

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2020
@bors
Copy link
Contributor

bors commented Jul 25, 2020

⌛ Testing commit 654c180 with merge 0e11fc8...

@bors
Copy link
Contributor

bors commented Jul 25, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing 0e11fc8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2020
@bors bors merged commit 0e11fc8 into rust-lang:master Jul 25, 2020
@bors bors mentioned this pull request Jul 25, 2020
Merged
@poliorcetics poliorcetics deleted the clarify-vec-drain-doc branch July 25, 2020 08:29
@ssomers ssomers mentioned this pull request Jan 11, 2022
Closed
@ssomers ssomers mentioned this pull request Feb 9, 2022
Closed
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@cramertj cramertj

Labels
A-collections Area: std::collections. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

drain() doc of vector is unclear
6 participants
@poliorcetics @rust-highfive @jyn514 @bors @cuviper @cramertj