Improve "important traits" popup display on mobile #74555
Conversation
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
I'll extend the popup dismissal in another PR then. @bors: r=Manishearth |
|
📌 Commit 995d63a has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
|
So I was intending to batch these changes along with some others, namely:
Feel free to make those in this same PR, or we can just land this and someone will make 'em later.
Hmmm. I'm not sure! It would be nice if you could make multiple popups open. I'm not a big fan of "click outside to close" UIs on mobile because they're easy to misclick, but that might just be a personal quirk. |
I think it deserves a PR on its own since it's wording which is a different purpose that the current PR. Also, following the topic on the internals forum, it seems to be active so I expect some comments, so better put it into its own PR.
This is also a fair concern. Should we update a thread or something along the line to check people's preferences about it? We close the other popups (at least the "help" popup) when clicking outside, but it's a big popup, so I don't really know... |
|
The other popups are modal, this isn't, this is a tooltip. Worth posting on the thread though!
Sounds good. |
…arth Rollup of 13 pull requests Successful merges: - rust-lang#72714 (Fix debug assertion in typeck) - rust-lang#73197 (Impl Default for ranges) - rust-lang#73323 (wf: check foreign fn decls for well-formedness) - rust-lang#74051 (disallow non-static lifetimes in const generics) - rust-lang#74376 (test caching opt_const_param_of on disc) - rust-lang#74501 (Ayu theme: Use different background color for Run button) - rust-lang#74505 (Fix search input focus in ayu theme) - rust-lang#74522 (Update sanitizer docs) - rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute) - rust-lang#74552 (Stabilize TAU constant.) - rust-lang#74555 (Improve "important traits" popup display on mobile) - rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern) - rust-lang#74561 (update backtrace-rs) Failed merges: r? @ghost
I implemented what @XAMPPRocky suggested in the internals thread topic. I can confirm it works nicely.
r? @Manishearth
@Manishearth: By the way: I realized that when you click on the "i", you have to click again to make the popup disappear. Do you want me to extend the popup removal to any click outside the popup?