Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize default providers only once #74347

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 15, 2020

This avoids copying a new Providers struct for each downstream crate
that wants to use it.

Follow-up to #74283 without the perf hit.

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Jul 15, 2020

LGTM, let's make sure this is a perf noop:
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 15, 2020

⌛ Trying commit 7798fe1ed63c51bc95c0a4601b9251e0f9ff4f31 with merge cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9...

@bors
Copy link
Contributor

bors commented Jul 15, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9 (cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9)

@rust-timer
Copy link
Collaborator

Queued cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9 with parent 23744c8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9): comparison url.

@jyn514
Copy link
Member Author

jyn514 commented Jul 15, 2020

No change in instructions, wall time is all over the place but looking at the last noise run that might be normal?

@eddyb
Copy link
Member

eddyb commented Jul 15, 2020

Yeah you can generally ignore wall-time. The important thing to look at here is helloworld-check, which had no changes.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 15, 2020

📌 Commit 7798fe1ed63c51bc95c0a4601b9251e0f9ff4f31 has been approved by eddyb

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 15, 2020
@jyn514
Copy link
Member Author

jyn514 commented Jul 15, 2020

@eddyb I'm going to rebase #73566 over this and merge them both at once so we don't have to wait for bors twice.

This avoids copying a new `Providers` struct for each downstream crate
that wants to use it.
@jyn514 jyn514 force-pushed the ive-got-a-small-query-for-you branch from 7798fe1 to f6764c4 Compare July 15, 2020 14:53
@Manishearth
Copy link
Member

@bors r=eddyb

still queueing this in case it gets rolled up

@bors
Copy link
Contributor

bors commented Jul 15, 2020

📌 Commit f6764c4 has been approved by eddyb

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2020
…arth

Rollup of 14 pull requests

Successful merges:

 - rust-lang#72973 (RISC-V GNU/Linux as host platform)
 - rust-lang#73918 (Clean up E0715 explanation)
 - rust-lang#73959 (Clean up E0716 explanation)
 - rust-lang#74119 (Remove `Compiler::compile()`.)
 - rust-lang#74196 (Add option to collapse automatically implementors)
 - rust-lang#74218 (Add margin after doc search results)
 - rust-lang#74276 (improve DiscriminantKind handling)
 - rust-lang#74291 (Added docs for `From<c_int>` for `ExitStatus`)
 - rust-lang#74294 (Update cross-compilation README)
 - rust-lang#74337 (Handle case of incomplete local ty more gracefully)
 - rust-lang#74344 (Remove string comparison and use diagnostic item instead)
 - rust-lang#74347 (Initialize default providers only once)
 - rust-lang#74353 (Edit docs for rustc_middle::dep_graph::dep_node)
 - rust-lang#74374 (Add a 1.45 release note on lto vs. embed-bitcode)

Failed merges:

 - rust-lang#74251 (Teach bootstrap about target files vs target triples)

r? @ghost
@bors bors merged commit dceafac into rust-lang:master Jul 16, 2020
@jyn514 jyn514 deleted the ive-got-a-small-query-for-you branch July 16, 2020 11:27
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants