Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrayVec in SparseBitSet. #74310

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Use ArrayVec in SparseBitSet. #74310

merged 1 commit into from
Jul 14, 2020

Conversation

nnethercote
Copy link
Contributor

Instead of SmallVec, because the maximum size is known.

r? @eddyb

@nnethercote
Use ArrayVec in SparseBitSet.
c492ca4 
Instead of `SmallVec`, because the maximum size is known.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2020
@nnethercote
Copy link
Contributor Author

I'm not sure if this will have a performance impact. It's conceivable, given that SparseBitSet is hot the borrow checker with some benchmarks.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 14, 2020

⌛ Trying commit c492ca4 with merge 5f73a0df765ce2b9e0b5c8be0815be62eaf83df0...

eddyb
eddyb approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after perf results

@bors
Copy link
Contributor

bors commented Jul 14, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 5f73a0df765ce2b9e0b5c8be0815be62eaf83df0 (5f73a0df765ce2b9e0b5c8be0815be62eaf83df0)

@rust-timer
Copy link
Collaborator

Queued 5f73a0df765ce2b9e0b5c8be0815be62eaf83df0 with parent 9d09331, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (5f73a0df765ce2b9e0b5c8be0815be62eaf83df0): comparison url.

@nnethercote
Copy link
Contributor Author

It's a small but clear win, which is nice given that it also makes the code slightly nicer.

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Jul 14, 2020

📌 Commit c492ca4 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
@Manishearth
Rollup merge of rust-lang#74310 - nnethercote:use-ArrayVec-in-SparseB…
6261805 
…itSet, r=eddyb

Use `ArrayVec` in `SparseBitSet`.

Instead of `SmallVec`, because the maximum size is known.

r? @eddyb
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2020
@bors
Auto merge of rust-lang#74330 - Manishearth:rollup-mrc09pb, r=Manishe…
2002eba 
…arth

Rollup of 15 pull requests

Successful merges:

 - rust-lang#71237 (Add Ayu theme to rustdoc)
 - rust-lang#73720 (Clean up E0704 error explanation)
 - rust-lang#73866 (Obviate #[allow(improper_ctypes_definitions)])
 - rust-lang#73965 (typeck: check for infer before type impls trait)
 - rust-lang#73986 (add (unchecked) indexing methods to raw (and NonNull) slices)
 - rust-lang#74173 (Detect tuple struct incorrectly used as struct pat)
 - rust-lang#74220 (Refactor Windows `parse_prefix`)
 - rust-lang#74227 (Remove an unwrap in layout computation)
 - rust-lang#74239 (Update llvm-project to latest origin/rustc/10.0-2020-05-05 commit )
 - rust-lang#74257 (don't mark linux kernel module targets as a unix environment)
 - rust-lang#74270 (typeck: report placeholder type error w/out span)
 - rust-lang#74296 (Clarify the description for rfind)
 - rust-lang#74310 (Use `ArrayVec` in `SparseBitSet`.)
 - rust-lang#74316 (Remove unnecessary type hints from Wake internals)
 - rust-lang#74324 (Update Clippy)

Failed merges:

r? @ghost
@bors bors merged commit 99c0b97 into rust-lang:master Jul 14, 2020
@nnethercote nnethercote deleted the use-ArrayVec-in-SparseBitSet branch July 15, 2020 00:59
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nnethercote @rust-timer @bors @eddyb @cuviper @rust-highfive