rustpkg: Make rustpkg commands work without a package ID #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@catamorphism this seems to be a legitimate failure, http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/203/steps/test/logs/stdio |
|
@cmr Yeah, I'm working on it. |
|
I'll re-push after #7681 lands. |
`rustpkg build`, if executed in a package source directory inside a workspace, will now build that package. By "inside a workspace" I mean that the parent directory has to be called `src`, and rustpkg will create a `build` directory in .. if there isn't already one. Same goes for `rustpkg install` and `rustpkg clean`. For the time being, `rustpkg build` (etc.) will still error out if you run it inside a directory whose parent isn't called `src`. I'm not sure whether or not it's desirable to have it do something in a non-workspace directory.
|
r? @graydon -- This was approved before, but I've changed a fair amount. |
bors
added a commit
that referenced
this pull request
Jul 20, 2013
r? @brson `rustpkg build`, if executed in a package source directory inside a workspace, will now build that package. By "inside a workspace" I mean that the parent directory has to be called `src`, and rustpkg will create a `build` directory in .. if there isn't already one. Same goes for `rustpkg install` and `rustpkg clean`. For the time being, `rustpkg build` (etc.) will still error out if you run it inside a directory whose parent isn't called `src`. I'm not sure whether or not it's desirable to have it do something in a non-workspace directory.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
wildcard_enum_match_arm lint takes the enum origin into account fixes rust-lang#7419 --- changelog: Enhancement: [`wildcard_enum_match_arm`]: Now lints missing private variants, for local enums [rust-lang#10250](rust-lang/rust-clippy#10250) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson
rustpkg build, if executed in a package source directory insidea workspace, will now build that package. By "inside a workspace"
I mean that the parent directory has to be called
src, and rustpkgwill create a
builddirectory in .. if there isn't already one.Same goes for
rustpkg installandrustpkg clean.For the time being,
rustpkg build(etc.) will still error out ifyou run it inside a directory whose parent isn't called
src.I'm not sure whether or not it's desirable to have it do something
in a non-workspace directory.