Avoid "blacklist" #74150

tamird · 2020-07-08T13:56:03Z

Other terms are more inclusive and precise.

Clippy still has a lint named "blacklisted-name", but renaming it would
be a breaking change, so is left for future work.

The target configuration option "abi-blacklist" has been depreciated and
renamed to "unsupported-abis". The old name continues to work.

ljedrz · 2020-07-08T14:03:21Z

Not sure about this being more precise, as "blocklisted" is not a word.

taiki-e · 2020-07-08T14:33:32Z

I feel the antonym of "allow" is "deny", is there any reason to prefer "blocklist" instead of "denylist"?
https://en.wikipedia.org/wiki/Blacklist_(computing)

Also, I'm not familiar with the code where this change actually applies, but in general, I think "blocked-"/"allowed-"/"denied-" is simpler and clearer than "blocklisted-"/"allowlisted-"/"denylisted-".

src/librustc_target/spec/mod.rs

src/librustc_error_codes/error_codes/E0570.md

src/librustc_target/spec/mod.rs

Manishearth · 2020-07-08T14:40:17Z

r? @rust-lang/compiler

Clippy has support for renaming lints in a non breaking way (as aliases), but I would do that in a separate PR to the clippy repo since it's still a slight behavior change

src/librustc_resolve/imports.rs

tamird · 2020-07-08T15:19:37Z

Implemented all the suggestions. Thanks for the reviews!

nikomatsakis

Big 👍 on this version. I like the new names, much clearer than both the original and the intermediate states.

nikomatsakis · 2020-07-08T15:24:20Z

r? @nikomatsakis

nikomatsakis · 2020-07-08T15:26:22Z

Tagging for release notes:

We should mention that the target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis" (the older name continues to work).

taiki-e · 2020-07-08T15:29:45Z

@tamird Can you update the title of PR? "blocklist" is no longer used.

IRSmoh

this is a pointless breaking change that only offends arm chair fake oppression olympic medalists. the word 'blacklist' is a well known term and has been used for hundreds of years -- long before anyone even considered it remotely related to 'slavery' -- which is still being practiced in the middle east but no one cares about it there.

If you're going to change something, make it a useful change not a change that makes people reach for something known, wonder why its missing then have to go read some pointless docs. breaking consistency with other tooling just for appeasement is not a good idea.

nikomatsakis · 2020-07-08T15:46:34Z

@IRSmoh This comment is unconstructive and dismissive, not to mention factually inaccurate (no breaking change has occurred, although there is a deprecation and rename). Further, the change is clearly not "pointless", there's a very clear motivation. As the PR header states, the older terminology is exclusive (for pretty obvious historical reasons) and it's also rather imprecise (looking over the diff I think makes clear that we can choose alternative terminology that expresses its purpose more clearly). There would be respectful ways to engage if you're really unclear on what the point of this PR is and would like to learn about that, or ask questions. Such comments might be fine, but unconstructive/dismissive/inaccurate/disrespectful comments of this ilk will be moderated out.

Other terms are more inclusive and precise. Clippy still has a lint named "blacklisted-name", but renaming it would be a breaking change, so is left for future work. The target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis". The old name continues to work.

tamird · 2020-07-08T16:09:17Z

Done, thanks @nikomatsakis!

BurntSushi · 2020-07-08T16:11:24Z

Moderation note: Unconstructive comments will be removed from this PR thread. If the volume of unconstructive comments gets too high or if the PR thread gets too heated, then the moderation team will lock this thread as well.

As always, if you would like to discuss moderation, then please email us: rust-mods@rust-lang.org. Comments discussing moderation in this PR will be removed.

pnkfelix · 2020-07-08T16:30:32Z

(I'm nominating because I want this PR to be discussed in tomorrows meeting; however, my nomination should not be interpreted as blocking the PR. I'm fine with it being r+'ed, assuming team feedback has been incorporated.)

nikomatsakis · 2020-07-08T17:01:10Z

@bors r+

bors · 2020-07-08T17:01:11Z

📌 Commit 1e567c1 has been approved by nikomatsakis

Avoid "blacklist" Other terms are more inclusive and precise. Clippy still has a lint named "blacklisted-name", but renaming it would be a breaking change, so is left for future work. The target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis". The old name continues to work.

Owez · 2020-07-08T18:04:33Z

"Blacklist" isn't an offensive term but I agree allowlist/denylist is a clearer option, as long as there aren't any breaking changes downstream outside of closely-related tools like clippy that are fixed already it's fine in my opinion

Avoid "blacklist" Other terms are more inclusive and precise. Clippy still has a lint named "blacklisted-name", but renaming it would be a breaking change, so is left for future work. The target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis". The old name continues to work.

pnkfelix · 2020-07-09T15:37:56Z

discussed in today's T-compiler meeting. Removing nomination tag.

Avoid "blacklist" Other terms are more inclusive and precise. Clippy still has a lint named "blacklisted-name", but renaming it would be a breaking change, so is left for future work. The target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis". The old name continues to work.

@ghost

…arth Rollup of 14 pull requests Successful merges: - rust-lang#73292 (Fixing broken link for the Eq trait) - rust-lang#73791 (Allow for parentheses after macro intra-doc-links) - rust-lang#74070 ( Use for<'tcx> fn pointers in Providers, instead of having Providers<'tcx>.) - rust-lang#74077 (Use relative path for local links to primitives) - rust-lang#74079 (Eliminate confusing "globals" terminology.) - rust-lang#74107 (Hide `&mut self` methods from Deref in sidebar if there are no `DerefMut` impl for the type.) - rust-lang#74136 (Fix broken link in rustdocdoc) - rust-lang#74137 (Update cargo) - rust-lang#74142 (Liballoc use vec instead of vector) - rust-lang#74143 (Try remove unneeded ToString import in liballoc slice) - rust-lang#74146 (update miri) - rust-lang#74150 (Avoid "blacklist") - rust-lang#74184 (Add docs for intra-doc-links) - rust-lang#74188 (Tweak `::` -> `:` typo heuristic and reduce verbosity) Failed merges: - rust-lang#74122 (Start-up clean-up) - rust-lang#74127 (Avoid "whitelist") r? @ghost

according to various people on tech-pkg@, there are no problems with the Firefox build Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.][72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you cast a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.][72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

Pkgsrc changes: * Portability patches for Illumos have been intregrated upstream, so are no longer needed in pkgsrc. * Adjust one other patch, and update vendor/libc cargo checksum. Upstream changes: Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.] [72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you have a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.] [72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2020

CryZe reviewed Jul 8, 2020

View reviewed changes

src/librustc_target/spec/mod.rs Outdated Show resolved Hide resolved

lcnr reviewed Jul 8, 2020

View reviewed changes

src/librustc_error_codes/error_codes/E0570.md Outdated Show resolved Hide resolved

src/librustc_target/spec/mod.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Jul 8, 2020

View reviewed changes

src/librustc_resolve/imports.rs Outdated Show resolved Hide resolved

tamird force-pushed the blocklist branch from 41260f2 to a12037b Compare July 8, 2020 15:18

nikomatsakis approved these changes Jul 8, 2020

View reviewed changes

rust-highfive assigned nikomatsakis Jul 8, 2020

nikomatsakis added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 8, 2020

IRSmoh suggested changes Jul 8, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

tamird changed the title ~~Use "blocklist" instead of "blacklist"~~ Avoid "blacklist" Jul 8, 2020

tamird force-pushed the blocklist branch from a12037b to 1e567c1 Compare July 8, 2020 16:08

This comment has been minimized.

Sign in to view

pnkfelix added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 8, 2020

lcnr approved these changes Jul 8, 2020

View reviewed changes

LeSeulArtichaut added the I-nominated label Jul 8, 2020

Manishearth mentioned this pull request Jul 8, 2020

Rollup of 11 pull requests #74157

Closed

tamird mentioned this pull request Jul 8, 2020

Avoid "whitelist" #74127

Merged

Manishearth mentioned this pull request Jul 8, 2020

Rollup of 13 pull requests #74158

Closed

Manishearth mentioned this pull request Jul 8, 2020

Rollup of 14 pull requests #74166

Closed

pnkfelix removed the I-nominated label Jul 9, 2020

Manishearth mentioned this pull request Jul 9, 2020

Rollup of 16 pull requests #74190

Closed

Manishearth mentioned this pull request Jul 9, 2020

Rollup of 16 pull requests #74191

Closed

Manishearth mentioned this pull request Jul 9, 2020

Rollup of 14 pull requests #74195

Merged

bors merged commit d4d1111 into rust-lang:master Jul 10, 2020

tamird deleted the blocklist branch July 11, 2020 10:28

saschanaz mentioned this pull request Dec 31, 2020

Consider deprecating whitelist / blacklist APIs rust-lang/rust-bindgen#1812

Closed

Manishearth mentioned this pull request Feb 16, 2021

Move away from "whitelist"/"blacklist" terminology rust-lang/rust-bindgen#1997

Closed

cuviper added this to the 1.46 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid "blacklist" #74150

Avoid "blacklist" #74150

tamird commented Jul 8, 2020 •

edited

Loading

ljedrz commented Jul 8, 2020

taiki-e commented Jul 8, 2020 •

edited

Loading

Manishearth commented Jul 8, 2020

tamird commented Jul 8, 2020

nikomatsakis left a comment

nikomatsakis commented Jul 8, 2020

nikomatsakis commented Jul 8, 2020

taiki-e commented Jul 8, 2020 •

edited

Loading

IRSmoh left a comment

nikomatsakis commented Jul 8, 2020

This comment has been minimized.

tamird commented Jul 8, 2020

BurntSushi commented Jul 8, 2020 •

edited

Loading

This comment has been minimized.

pnkfelix commented Jul 8, 2020

nikomatsakis commented Jul 8, 2020

bors commented Jul 8, 2020

Owez commented Jul 8, 2020

pnkfelix commented Jul 9, 2020

Avoid "blacklist" #74150

Avoid "blacklist" #74150

Conversation

tamird commented Jul 8, 2020 • edited Loading

ljedrz commented Jul 8, 2020

taiki-e commented Jul 8, 2020 • edited Loading

Manishearth commented Jul 8, 2020

tamird commented Jul 8, 2020

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis commented Jul 8, 2020

nikomatsakis commented Jul 8, 2020

taiki-e commented Jul 8, 2020 • edited Loading

IRSmoh left a comment

Choose a reason for hiding this comment

nikomatsakis commented Jul 8, 2020

This comment has been minimized.

tamird commented Jul 8, 2020

BurntSushi commented Jul 8, 2020 • edited Loading

This comment has been minimized.

pnkfelix commented Jul 8, 2020

nikomatsakis commented Jul 8, 2020

bors commented Jul 8, 2020

Owez commented Jul 8, 2020

pnkfelix commented Jul 9, 2020

tamird commented Jul 8, 2020 •

edited

Loading

taiki-e commented Jul 8, 2020 •

edited

Loading

taiki-e commented Jul 8, 2020 •

edited

Loading

BurntSushi commented Jul 8, 2020 •

edited

Loading