Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #74114

Closed
wants to merge 26 commits into from

Commits on Jun 29, 2020

  1. typeck: adding type information to projection

    This commit modifies the Place as follow:
    * remove 'ty' from ProjectionKind
    * add type information into to Projection
    * replace 'ty' in Place with 'base_ty'
    * introduce 'ty()' in `Place` to return the final type of the `Place`
    * introduce `ty_before_projection()` in `Place` to return the type of
      a `Place` before i'th projection is applied
    
    Closes rust-lang/project-rfc-2229#5
    Azhng committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    7d7221c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. libstd/net/tcp.rs: #![deny(unsafe_op_in_unsafe_fn)]

    Enclose unsafe operations in unsafe blocks
    ryr3 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    8dc1e42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5141e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0fcb7da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc61cca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cdabdfa View commit details
    Browse the repository at this point in the history
  6. Update rustdoc tests

    GuillaumeGomez committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    2453946 View commit details
    Browse the repository at this point in the history
  7. Fix links

    GuillaumeGomez committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    af29620 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e955beb View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2020

  1. Fix const prop ICE

    we used to erase the local just before we tried to read it for diagnostics
    oli-obk committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    ee8dd4e View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2020

  1. rustdoc: Restore underline text decoration on hover for FQN in header

    This causes the components of FQN's to behave similarly to other links
    in the contents of rustdoc-styled pages.
    
    I (and I hope others at least in part) have found the prior design to be
    somewhat confusing, as it is not clear (upon hovering) that the various
    parts of the FQN are actually links that the user can navigate to.
    
    In short, this patch makes links in the FQN have an underline when the
    user hovers over them, more clearly indicating that they can be used for
    navigation.
    
    Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
    rye committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    2f31426 View commit details
    Browse the repository at this point in the history
  2. Remove unused RUSTC_DEBUG_ASSERTIONS

    Since rust-lang#73374 the rustc wrapper no longer configures debug assertions
    based on RUSTC_DEBUG_ASSERTIONS environment variable.
    tmiasko committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    5fa19ad View commit details
    Browse the repository at this point in the history
  3. Add read_exact_at and write_all_at to WASI's FileExt

    This adds `read_exact_at` and `write_all_at` to WASI's `FileExt`,
    similar to the Unix versions of the same names.
    sunfishcode committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    f226e6b View commit details
    Browse the repository at this point in the history
  4. Fix the return type of Windows' OpenOptionsExt::security_qos_flags.

    This adjusts the return type of Windows' `OpenOptionsExt::security_qos_flags`
    to be consistent with the other functions in the trait.
    sunfishcode committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    6196eaa View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Always resolve type@primitive as a primitive, not a module

    Previously, if there were a module in scope with the same name as the
    primitive, that would take precedence. Coupled with
    rust-lang#58699, this made it impossible
    to link to the primitive when that module was in scope.
    
    This approach could be extended so that `struct@foo` would no longer resolve
    to any type, etc. However, it could not be used for glob imports:
    
    ```rust
    pub mod foo {
      pub struct Bar;
    }
    
    pub enum Bar {}
    use foo::*;
    
    // This is expected to link to `inner::Bar`, but instead it will link to the enum.
    /// Link to [struct@Bar]
    pub struct MyDocs;
    ```
    
    The reason for this is that this change does not affect the resolution
    algorithm of rustc_resolve at all. The only reason we could special-case
    primitives is because we have a list of all possible primitives ahead of time.
    jyn514 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    e46c187 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7610ab3 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#70563 - GuillaumeGomez:page-hash-handling, …

    …r=ollie27,kinnison
    
    [rustdoc] Page hash handling
    
    Fixes rust-lang#70476
    
    A good example to see the change is to use this URL: https://doc.rust-lang.org/nightly/std/string/struct.String.html#from_iter.v-3
    
    After the change, it actually goes to the target element (and change the page hash to something more clear for the users).
    
    r? @kinnison
    
    cc @ollie27
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    99fc337 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#73870 - sexxi-goose:projection-ty, r=nikoma…

    …tsakis
    
    typeck: adding type information to projection
    
    This commit modifies the Place as follow:
    * remove 'ty' from ProjectionKind
    * add type information into to Projection
    * replace 'ty' in Place with 'base_ty'
    * introduce 'ty()' in `Place` to return the final type of the `Place`
    * introduce `ty_before_projection()` in `Place` to return the type of
      a `Place` before i'th projection is applied
    
    Closes rust-lang/project-rfc-2229#5
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    4d24341 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73962 - ryr3:unsafe_tcp, r=LukasKalbertodt

    libstd/net/tcp.rs: #![deny(unsafe_op_in_unsafe_fn)]
    
    Enclose unsafe operations in unsafe blocks for net/tcp.rs. Fixes part of rust-lang#73904.
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    59112d3 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#74067 - rye:rustdoc-fqn-hover-underline, r=…

    …GuillaumeGomez
    
    rustdoc: Restore underline text decoration on hover for FQN in header
    
    This causes the components of FQN's (e.g. `std`, `net`, and `Ipv4Addr` of the FQN `std::net::Ipv4Addr`) to behave similarly to other links in the contents of rustdoc-styled pages. When the user hovers over them, more clearly indicating that they can be used for navigation.
    
    I (and I hope others at least in part) have found the prior design to be somewhat confusing, as it is not clear (upon hovering) that the various parts of the FQN are actually links that the user can navigate to.
    
    <details><summary>📸 Before, mouse hovered over "net" in the FQN</summary>
    <img alt="A rustdoc page with the mouse hovered over the fully-qualified name in the page header, producing no visual change" src="https://user-images.githubusercontent.com/1566689/86538363-4c827000-bebb-11ea-8291-5ea6b85d7e19.png" />
    </details>
    <details><summary>📸 After, mouse hovered over "net" in the FQN</summary>
    <img alt="A rustdoc page with the mouse hovered over the fully-qualified name in the page header, now with an underline showing up under the word hovered over by the mouse" src="https://user-images.githubusercontent.com/1566689/86538471-d3374d00-bebb-11ea-9bb3-7aa2d7a4800b.png" />
    </details>
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    5c267ae View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#74074 - sunfishcode:windows-openoptionsext-…

    …return-type, r=LukasKalbertodt
    
    Fix the return type of Windows' `OpenOptionsExt::security_qos_flags`.
    
    This adjusts the return type of Windows' `OpenOptionsExt::security_qos_flags`
    to be consistent with the other functions in the trait.
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    87b8681 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#74076 - sunfishcode:wasi-fileext-newmethods…

    …, r=alexcrichton
    
    Add `read_exact_at` and `write_all_at` to WASI's `FileExt`
    
    This adds `read_exact_at` and `write_all_at` to WASI's `FileExt`,
    similar to the Unix versions of the same names.
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    51d7220 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#74078 - jyn514:lut, r=Manishearth

    Always resolve type@primitive as a primitive, not a module
    
    Previously, if there were a module in scope with the same name as the
    primitive, that would take precedence. Coupled with
    rust-lang#58699, this made it impossible
    to link to the primitive when that module was in scope.
    
    This approach could be extended so that `struct@foo` would no longer resolve
    to any type, etc. However, it could not be used for glob imports:
    
    ```rust
    pub mod foo {
      pub struct Bar;
    }
    
    pub enum Bar {}
    use foo::*;
    
    // This is expected to link to `inner::Bar`, but instead it will link to the enum.
    /// Link to [struct@Bar]
    pub struct MyDocs;
    ```
    
    The reason for this is that this change does not affect the resolution
    algorithm of rustc_resolve at all. The only reason we could special-case
    primitives is because we have a list of all possible primitives ahead of time.
    
    Closes rust-lang#74063
    
    r? @Manishearth
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6a8e601 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#74090 - tmiasko:rustc-debug-assertions, r=R…

    …alfJung
    
    Remove unused RUSTC_DEBUG_ASSERTIONS
    
    Since rust-lang#73374 the rustc wrapper no longer configures debug assertions
    based on RUSTC_DEBUG_ASSERTIONS environment variable.
    
    r? @RalfJung
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    b5cfc94 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#74102 - oli-obk:const_prop_icde, r=wesleywiser

    Fix const prop ICE
    
    we used to erase the local just before we tried to read it for diagnostics
    
    fixes rust-lang#73993
    
    r? @wesleywiser
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    8511ed6 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#74112 - pierwill:patch-2, r=sfackler

    Expand abbreviation in core::ffi description
    Dylan-DPC committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    f36490d View commit details
    Browse the repository at this point in the history