Explain exhaustive matching on {usize,isize} maximum values #73937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
reviewed
Jul 1, 2020
lcnr
approved these changes
Jul 1, 2020
varkor
reviewed
Jul 3, 2020
JohnTitor
force-pushed
the
note-exhaustive-sized-int
branch
from
372f436
to
974aec0
Compare
JohnTitor
force-pushed
the
note-exhaustive-sized-int
branch
from
974aec0
to
b93ecc1
Compare
|
Thanks! @bors r+ rollup |
|
📌 Commit b93ecc1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2020
…arth Rollup of 12 pull requests Successful merges: - rust-lang#72688 (added .collect() into String from Box<str>) - rust-lang#73787 (Add unstable docs for rustc_attrs) - rust-lang#73834 (Some refactoring around intrinsic type checking) - rust-lang#73871 (Fix try_print_visible_def_path for Rust 2018) - rust-lang#73937 (Explain exhaustive matching on {usize,isize} maximum values) - rust-lang#73973 (Use `Span`s to identify unreachable subpatterns in or-patterns) - rust-lang#74000 (add `lazy_normalization_consts` feature gate) - rust-lang#74025 (Remove unnecessary release from Arc::try_unwrap) - rust-lang#74027 (Convert more `DefId`s to `LocalDefId`s) - rust-lang#74055 (Fix spacing in Iterator fold doc) - rust-lang#74057 (expected_found `&T` -> `T`) - rust-lang#74064 (variant_count: avoid incorrect dummy implementation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording is taken from https://github.com/rust-lang/rfcs/blob/master/text/2591-exhaustive-integer-pattern-matching.md#reference-level-explanation.
Fixes #73919
r? @varkor