Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #73850

Closed
wants to merge 13 commits into from

Commits on Jun 5, 2020

  1. Configuration menu
    Copy the full SHA
    8bc6b5b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Merge pull request rust-lang#2 from rust-lang/master

    update master
    TyPR124 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    00ef461 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b71a3e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Configuration menu
    Copy the full SHA
    14d0370 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4595fa8 View commit details
    Browse the repository at this point in the history
  3. Fix markdown rendering in librustc_lexer docs

    Use back-ticks instead of quotation marks in docs for the block comment
    variant of TokenKind.
    pierwill committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    49c1018 View commit details
    Browse the repository at this point in the history
  4. Edit cursor.prev() method docs in lexer

    Fix missing punctuation
    pierwill committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    40c74a7 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73032 - yoshuawuyts:stabilize-leading_trail…

    …ing_ones, r=Amanieu
    
    stabilize leading_trailing_ones
    
    This PR stabilizes the `leading_trailing_ones` feature. It's been available on nightly since the start of the year, and hasn't had any issues since. It seems unlikely we'll want to change this, so following up on @djc's suggestion in rust-lang#57969 (comment) I'd like to put forward this PR to stabilize the feature and make it part of `1.46.0`. Thanks!
    
    cc/ @djc @rust-lang/libs
    Dylan-DPC committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    654c56d View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73752 - TyPR124:invalid-parameter-error, r=…

    …LukasKalbertodt
    
    Remap Windows ERROR_INVALID_PARAMETER to ErrorKind::InvalidInput from Other
    
    I don't know if this is acceptable or how likely it is to break existing code, but it seem to me ERROR_INVALID_PARAMETER "The parameter is incorrect" should map to ErrorKind::InvalidInput "A parameter was incorrect". Previously this value fell through to ErrorKind::Other.
    
    I can't speak for anyone but myself, but I instinctively thought it would be InvalidInput.
    Dylan-DPC committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    15382aa View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73841 - tmiasko:print-region-graph, r=Mark-…

    …Simulacrum
    
    Remove defunct `-Z print-region-graph`
    Dylan-DPC committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    b83eba2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73846 - pierwill:pierwill-patch-2, r=joshtr…

    …iplett
    
    Fix comma in debug_assert! docs
    Dylan-DPC committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    7fd6317 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73847 - pierwill:pierwill-cursor-doc, r=mat…

    …thewjasper
    
    Edit cursor.prev() method docs in lexer
    
    Fix missing punctuation
    Dylan-DPC committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    bf806f6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73848 - pierwill:pierwill-lexer-block-doc, …

    …r=jonas-schievink
    
    Fix markdown rendering in librustc_lexer docs
    
    Use back-ticks instead of quotation marks in docs for the block comment variant of TokenKind.
    
    ## [Before](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_lexer/enum.TokenKind.html#variant.BlockComment) and after
    
    <img width="1103" alt="Screen Shot 2020-06-28 at 1 22 30 PM" src="https://user-images.githubusercontent.com/19642016/85957562-446a8380-b943-11ea-913a-442cf7744083.png">
    
    <img width="1015" alt="Screen Shot 2020-06-28 at 1 28 29 PM" src="https://user-images.githubusercontent.com/19642016/85957566-4af8fb00-b943-11ea-8fef-a09c1d586772.png">
    
    ## Question
    
    For visual consistency, should we use back-ticks throughout the docs for these enum variants?
    Dylan-DPC committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    101331e View commit details
    Browse the repository at this point in the history