Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order correctly the sections in the sidebar #73372

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

GuillaumeGomez
Copy link
Member

Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content".

r? @kinnison

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2020
@kinnison
Copy link
Contributor

Keeping the sidebar ordering in sync with the main content makes sense to me. I don't see any reason why this change would fail to build unless there are ordering sensitive tests out there, so.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 15, 2020

📌 Commit b67bdb5 has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2020
@RalfJung
Copy link
Member

@bors rollup
(please mark tiny PRs that are unlikely to fail CI for rollup, thanks :)

@kinnison
Copy link
Contributor

@RalfJung Okay, I'll try and remember that, thanks for the pointer.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
…tions, r=kinnison

Re-order correctly the sections in the sidebar

Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content".

r? @kinnison
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
…tions, r=kinnison

Re-order correctly the sections in the sidebar

Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content".

r? @kinnison
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 16, 2020
…tions, r=kinnison

Re-order correctly the sections in the sidebar

Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content".

r? @kinnison
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 16, 2020
…tions, r=kinnison

Re-order correctly the sections in the sidebar

Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content".

r? @kinnison
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 16, 2020
…tions, r=kinnison

Re-order correctly the sections in the sidebar

Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content".

r? @kinnison
This was referenced Jun 16, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 16, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#73237 (Check for overflow in DroplessArena and align returned memory)
 - rust-lang#73339 (Don't run generator transform when there's a TyErr)
 - rust-lang#73372 (Re-order correctly the sections in the sidebar)
 - rust-lang#73373 (Use track caller for bug! macro)
 - rust-lang#73380 (Add more info to `x.py build --help` on default value for `-j JOBS`.)
 - rust-lang#73381 (Fix typo in docs of std::mem)
 - rust-lang#73389 (Use `Ipv4Addr::from<[u8; 4]>` when possible)
 - rust-lang#73400 (Fix forge-platform-support URL)

Failed merges:

r? @ghost
@bors bors merged commit 6c44519 into rust-lang:master Jun 16, 2020
@GuillaumeGomez GuillaumeGomez deleted the re-order-sidebar-sections branch June 19, 2020 11:24
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants