Implement static mut
#7291
Merged
Implement static mut
#7291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, test coverage seems fine to me. I'd r+ it, but @bors has gone mad. |
|
\o/ |
|
🎆 |
|
Excellent, thanks! |
|
@alexcrichton: sadly, already needs a rebase |
|
@thestinger, should be ready to go again |
bors
added a commit
that referenced
this pull request
Jun 25, 2013
This adds both `static mut` items and `static mut` foreign items. This involved changing far less code than I thought it was going to, but the tests seem to pass and the variables seem functional. I'm more than willing to write more tests, so suggestions are welcome! Closes #553
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
Added new `non_zero_suggestions` lint Created lint based on the suggestions in rust-lang#7291 - \[x] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` ---- changelog: new [`non_zero_suggestions`] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds both
static mutitems andstatic mutforeign items. This involved changing far less code than I thought it was going to, but the tests seem to pass and the variables seem functional.I'm more than willing to write more tests, so suggestions are welcome!
Closes #553