Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for trailing comma when suggesting where clauses #72715

Merged
merged 2 commits into from
May 31, 2020
Merged

Account for trailing comma when suggesting where clauses #72715

merged 2 commits into from
May 31, 2020

Conversation

estebank
Copy link
Contributor

Fix #72693.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2020
@petrochenkov
Copy link
Contributor

Nice, one instance of BytePos arithmetic fewer.
@bors r+

@bors
Copy link
Contributor

bors commented May 29, 2020

📌 Commit 0fea70673d166a88a9453535a64595c9d087130e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2020
@petrochenkov
Copy link
Contributor

@bors r-
r=me with the unused variable causing CI error fixed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2020
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the trailing-comma-where branch from 0fea706 to 0d18136 Compare May 29, 2020 17:12
@estebank
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented May 29, 2020

📌 Commit 0d18136 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request May 31, 2020
@RalfJung
Rollup merge of rust-lang#72715 - estebank:trailing-comma-where, r=pe…
321d39b 
…trochenkov

Account for trailing comma when suggesting `where` clauses

Fix rust-lang#72693.
@RalfJung RalfJung mentioned this pull request May 31, 2020
Closed
@RalfJung RalfJung mentioned this pull request May 31, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2020
@bors
Auto merge of rust-lang#72813 - RalfJung:rollup-4ko6q8j, r=RalfJung
f6072ca 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#72683 (from_u32_unchecked: check validity, and fix UB in Wtf8)
 - rust-lang#72715 (Account for trailing comma when suggesting `where` clauses)
 - rust-lang#72745 (generalize Borrow<[T]> for Interned<'tcx, List<T>>)
 - rust-lang#72749 (Update stdarch submodule to latest head)
 - rust-lang#72781 (Use `LocalDefId` instead of `NodeId` in `resolve_str_path_error`)

Failed merges:

r? @ghost
@bors bors merged commit b714f5c into rust-lang:master May 31, 2020
@estebank estebank deleted the trailing-comma-where branch November 9, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extraneous comma in trait bound suggestion
4 participants
@estebank @rust-highfive @petrochenkov @bors