Only capture tokens for items with outer attributes #72585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit ac55d4ba1e26fecbd103e5faf949c92cc72e0f14 with merge dcffa690dddd8e255c2b61a282371cfe7e1d1573... |
petrochenkov
added
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
|
☀️ Try build successful - checks-azure |
|
Queued dcffa690dddd8e255c2b61a282371cfe7e1d1573 with parent a0f06d1, future comparison URL. |
|
Finished benchmarking try commit dcffa690dddd8e255c2b61a282371cfe7e1d1573, comparison URL. |
Aaron1011
force-pushed
the
feature/opt-item-tokens
branch
from
ac55d4b to
4e2696f
Compare
Aaron1011
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 4e2696f has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 28, 2020
…r=petrochenkov Only capture tokens for items with outer attributes Suggested by @petrochenkov in rust-lang#43081 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#72299 (more `LocalDefId`s) - rust-lang#72368 (Resolve overflow behavior for RangeFrom) - rust-lang#72441 (Fix ICE with explicit late-bound lifetimes) - rust-lang#72499 (Override Box::<[T]>::clone_from) - rust-lang#72521 (Properly handle InlineAsmOperand::SymFn when collecting monomorphized items) - rust-lang#72540 (mir: adjust conditional in recursion limit check) - rust-lang#72563 (multiple Return terminators are possible) - rust-lang#72585 (Only capture tokens for items with outer attributes) - rust-lang#72607 (Eagerly lower asm sub-expressions to HIR even if there is an error) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @petrochenkov in #43081 (comment)