Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #72102

Closed
wants to merge 16 commits into from
Closed

Conversation

RalfJung
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

GuillaumeGomez and others added 16 commits May 8, 2020 15:19
`eprintln!` gets swallowed by Cargo too easily.
…kinnison,ollie27

Deprecated emoji

Fixes rust-lang#67872.

r? @kinnison

cc @rust-lang/rustdoc
use min_specialization for some rustc crates where it requires no changes

and add FIXME for the rest

Cc @matthewjasper
…ochenkov

Incomplete features can also be unsound

Some incomplete features do not just ICE, they are also currently unsound (e.g. rust-lang#72029, and also `specialization` -- which is not yet marked incomplete but [should be](rust-lang#71420)). This makes the message reflect that.

While at it I also added a link to the tracking issue, which hopefully should explain what is incomplete/unsound about the feature.
Emit a warning when optimization fuel runs out

`eprintln!` gets swallowed by Cargo too easily.
doc: minus (U+2212) instead of dash (U+002D) for negative infinity

Like rust-lang#67430, for the new associated constants.
@RalfJung
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented May 11, 2020

📌 Commit 19393d0 has been approved by RalfJung

@rustbot rustbot added the rollup A PR which is a rollup label May 11, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 11, 2020
@Dylan-DPC-zz
Copy link

Closing this. i'll recreate it later. currently we are testing some gha fixes and have another rollup going on.

@RalfJung RalfJung deleted the rollup-kve42l5 branch May 12, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants