Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement destructuring assignment #71156

Closed
wants to merge 28 commits into from
Closed

Implement destructuring assignment #71156

wants to merge 28 commits into from

Commits on Nov 4, 2020

  1. Add destructuring_assignment feature gate

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    a8c784c View commit details
    Browse the repository at this point in the history

  2. Allow recursive tuples on the LHS of assignments

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    fc4fd10 View commit details
    Browse the repository at this point in the history

  3. Handle slices and structs as well

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    397e914 View commit details
    Browse the repository at this point in the history

  4. Handle .. except in structs

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    7b10eec View commit details
    Browse the repository at this point in the history

  5. Fix tidy

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    7823897 View commit details
    Browse the repository at this point in the history

  6. Handle ordinary assignments as before

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    475cd1e View commit details
    Browse the repository at this point in the history

  7. Only lower tuple structs if in fact a constructor

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    a6562bd View commit details
    Browse the repository at this point in the history

  8. Disallow .. rest in struct on LHS of an assignment

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    5e39caa View commit details
    Browse the repository at this point in the history

  9. Check for constructors in early return condition

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    330b181 View commit details
    Browse the repository at this point in the history

  10. Add tests

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    27e43ae View commit details
    Browse the repository at this point in the history

  11. Allow _ as an expression

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    f54533b View commit details
    Browse the repository at this point in the history

  12. Allow _ on the LHS of an assignment to discard a value

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3631ab5 View commit details
    Browse the repository at this point in the history

  13. Allow .. in struct expressions on the LHS of assignments

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    1f65f5d View commit details
    Browse the repository at this point in the history

  14. Improve error message for struct expression missing a base expression… 

    … after `..`
    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    2415a64 View commit details
    Browse the repository at this point in the history

  15. Adjust comments and diagnostics

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    9b38750 View commit details
    Browse the repository at this point in the history

  16. Update feature gate issue

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    1841f2d View commit details
    Browse the repository at this point in the history

  17. Support (..)

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    76bcd89 View commit details
    Browse the repository at this point in the history

  18. Add more complex example

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    6b18424 View commit details
    Browse the repository at this point in the history

  19. Fix tests

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    ced8ce4 View commit details
    Browse the repository at this point in the history

  20. Fix handling of rest without base in LHS

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    fb02d99 View commit details
    Browse the repository at this point in the history

  21. Add additional tests for trailing ..

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    ac37e3c View commit details
    Browse the repository at this point in the history

  22. Add pre-expansion gating

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    f015a2e View commit details
    Browse the repository at this point in the history

  23. Make pre-expansion gate slightly less obnoxious

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    9a5d725 View commit details
    Browse the repository at this point in the history

  24. Fix ui-fulldeps test

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    fbced7d View commit details
    Browse the repository at this point in the history

  25. Fix rebase issues

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    60552c7 View commit details
    Browse the repository at this point in the history

  26. Add support for StructRest in clippy

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    8614f44 View commit details
    Browse the repository at this point in the history

  27. Prevent default match bindings in destructuring assignment

    @varkor @fanzier
    varkor authored and fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    a0d4c55 View commit details
    Browse the repository at this point in the history

  28. Fix rebase issue and test

    @fanzier
    fanzier committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    c25779a View commit details
    Browse the repository at this point in the history