Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: let config flags overwrite -A unused #70978

Merged
merged 1 commit into from
Apr 10, 2020
Merged

compiletest: let config flags overwrite -A unused #70978

merged 1 commit into from
Apr 10, 2020

Conversation

RalfJung
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2020
@RalfJung RalfJung mentioned this pull request Apr 10, 2020
Merged
@Mark-Simulacrum
Copy link
Member

Hm, I'm surprised this is necessary as I wouldn't expect host/target flags to be changing lint levels. But it also seems reasonable, so @bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2020

📌 Commit b973cb7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Apr 10, 2020 •
edited
Loading

@Mark-Simulacrum in Miri we are using host/target flags to overwrite the -A unused as we actually do want to be warned about unused code. This has caught some bad tests in the past that did not test what they were supposed to. (Miri uses the external fork of this code, but I figured I should keep this consistent with Manishearth/compiletest-rs#217.)

@RalfJung
Copy link
Member Author

@bors rollup

@RalfJung
Copy link
Member Author

r? @Mark-Simulacrum to match review

@Centril Centril mentioned this pull request Apr 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2020
@bors
Auto merge of rust-lang#70994 - Centril:rollup-lftv0a3, r=Centril
1406186 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#69745 (Use `PredicateObligation`s instead of `Predicate`s)
 - rust-lang#70938 (Add ThreadSanitizer test case)
 - rust-lang#70973 (Use forward traversal for unconditional recursion lint)
 - rust-lang#70978 (compiletest: let config flags overwrite -A unused)
 - rust-lang#70979 (Follow up on BTreeMap comments)
 - rust-lang#70981 (Rearrange BTreeMap::into_iter to match range_mut.)
 - rust-lang#70985 (Clean up E0512 explanation)
 - rust-lang#70988 (Setup the `@rustbot prioritize` command)
 - rust-lang#70991 (fix rustc-dev-guide's url in src/librustc_codegen_ssa)

Failed merges:

r? @ghost
@bors bors merged commit a5e06f2 into rust-lang:master Apr 10, 2020
@RalfJung RalfJung deleted the compiletest-flags branch April 11, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rust-highfive @Mark-Simulacrum @bors @nikomatsakis