Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend #69020 test to include reversed operand order. #70696

Merged
merged 3 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:28:22
|
LL | const NEG: i32 = -i32::MIN + T::NEG;
| ^^^^^^^^^ attempt to negate with overflow
|
= note: `#[deny(arithmetic_overflow)]` on by default

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:30:31
|
LL | const GEN: i32 = T::NEG + (-i32::MIN);
| ^^^^^^^^^^^ attempt to negate with overflow

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:33:22
|
LL | const ADD: i32 = (i32::MAX+1) + T::ADD;
| ^^^^^^^^^^^^ attempt to add with overflow

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:35:32
|
LL | const DDA: i32 = T::ADD + (i32::MAX+1);
| ^^^^^^^^^^^^ attempt to add with overflow

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:38:22
|
LL | const DIV: i32 = (1/0) + T::DIV;
| ^^^^^ attempt to divide by zero
|
= note: `#[deny(unconditional_panic)]` on by default

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:40:31
|
LL | const VID: i32 = T::DIV + (1/0);
| ^^^^^ attempt to divide by zero

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:43:22
|
LL | const OOB: i32 = [1][1] + T::OOB;
| ^^^^^^ index out of bounds: the len is 1 but the index is 1

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:45:31
|
LL | const BOO: i32 = T::OOB + [1][1];
| ^^^^^^ index out of bounds: the len is 1 but the index is 1

error: aborting due to 8 previous errors

Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:28:22
|
LL | const NEG: i32 = -i32::MIN + T::NEG;
| ^^^^^^^^^ attempt to negate with overflow
|
= note: `#[deny(arithmetic_overflow)]` on by default

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:30:31
|
LL | const GEN: i32 = T::NEG + (-i32::MIN);
| ^^^^^^^^^^^ attempt to negate with overflow

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:33:22
|
LL | const ADD: i32 = (i32::MAX+1) + T::ADD;
| ^^^^^^^^^^^^ attempt to add with overflow

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:35:32
|
LL | const DDA: i32 = T::ADD + (i32::MAX+1);
| ^^^^^^^^^^^^ attempt to add with overflow

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:38:22
|
LL | const DIV: i32 = (1/0) + T::DIV;
| ^^^^^ attempt to divide by zero
|
= note: `#[deny(unconditional_panic)]` on by default

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:40:31
|
LL | const VID: i32 = T::DIV + (1/0);
| ^^^^^ attempt to divide by zero

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:43:22
|
LL | const OOB: i32 = [1][1] + T::OOB;
| ^^^^^^ index out of bounds: the len is 1 but the index is 1

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:45:31
|
LL | const BOO: i32 = T::OOB + [1][1];
| ^^^^^^ index out of bounds: the len is 1 but the index is 1

error: aborting due to 8 previous errors

Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:28:22
|
LL | const NEG: i32 = -i32::MIN + T::NEG;
| ^^^^^^^^^ attempt to negate with overflow
|
= note: `#[deny(arithmetic_overflow)]` on by default

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:30:31
|
LL | const GEN: i32 = T::NEG + (-i32::MIN);
| ^^^^^^^^^^^ attempt to negate with overflow

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:33:22
|
LL | const ADD: i32 = (i32::MAX+1) + T::ADD;
| ^^^^^^^^^^^^ attempt to add with overflow

error: this arithmetic operation will overflow
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:35:32
|
LL | const DDA: i32 = T::ADD + (i32::MAX+1);
| ^^^^^^^^^^^^ attempt to add with overflow

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:38:22
|
LL | const DIV: i32 = (1/0) + T::DIV;
| ^^^^^ attempt to divide by zero
|
= note: `#[deny(unconditional_panic)]` on by default

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:40:31
|
LL | const VID: i32 = T::DIV + (1/0);
| ^^^^^ attempt to divide by zero

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:43:22
|
LL | const OOB: i32 = [1][1] + T::OOB;
| ^^^^^^ index out of bounds: the len is 1 but the index is 1

error: this operation will panic at runtime
--> $DIR/issue-69020-assoc-const-arith-overflow.rs:45:31
|
LL | const BOO: i32 = T::OOB + [1][1];
| ^^^^^^ index out of bounds: the len is 1 but the index is 1

error: aborting due to 8 previous errors

Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,16 @@ use std::i32;

pub trait Foo {
const NEG: i32;
const GEN: i32;
jumbatm marked this conversation as resolved.
Show resolved Hide resolved

const ADD: i32;
const DDA: i32;

const DIV: i32;
const VID: i32;

const OOB: i32;
const BOO: i32;
}

// These constants cannot be evaluated already (they depend on `T::N`), so
Expand All @@ -20,10 +27,21 @@ pub trait Foo {
impl<T: Foo> Foo for Vec<T> {
const NEG: i32 = -i32::MIN + T::NEG;
//~^ ERROR arithmetic operation will overflow
const GEN: i32 = T::NEG + (-i32::MIN);
//~^ ERROR arithmetic operation will overflow

const ADD: i32 = (i32::MAX+1) + T::ADD;
//~^ ERROR arithmetic operation will overflow
const DDA: i32 = T::ADD + (i32::MAX+1);
//~^ ERROR arithmetic operation will overflow

const DIV: i32 = (1/0) + T::DIV;
//~^ ERROR operation will panic
const VID: i32 = T::DIV + (1/0);
//~^ ERROR operation will panic

const OOB: i32 = [1][1] + T::OOB;
//~^ ERROR operation will panic
const BOO: i32 = T::OOB + [1][1];
//~^ ERROR operation will panic
}
30 changes: 0 additions & 30 deletions src/test/ui/consts/issue-69020.noopt.stderr

This file was deleted.

30 changes: 0 additions & 30 deletions src/test/ui/consts/issue-69020.opt.stderr

This file was deleted.

30 changes: 0 additions & 30 deletions src/test/ui/consts/issue-69020.opt_with_overflow_checks.stderr

This file was deleted.