Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0628 #69867

Merged
merged 5 commits into from
Mar 16, 2020
Merged

Add long error explanation for E0628 #69867

merged 5 commits into from
Mar 16, 2020

Conversation

ayushmishra2005
Copy link
Contributor

@ayushmishra2005 ayushmishra2005 commented Mar 9, 2020 •
edited
Loading

Add long explanation for the E0628 error code
Part of #61137

r? @GuillaumeGomez

@ayushmishra2005
Copy link
Contributor Author

r? @davidtwco

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2020
@ayushmishra2005
Copy link
Contributor Author

r? @Dylan-DPC

Dylan-DPC-zz
Dylan-DPC-zz suggested changes Mar 13, 2020
View reviewed changes
src/librustc_error_codes/error_codes/E0628.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0628.md Outdated Show resolved Hide resolved
ayushmishra2005 and others added 4 commits March 13, 2020 08:14
@ayushmishra2005 @Dylan-DPC
Update src/librustc_error_codes/error_codes/E0628.md
1305ae6 
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
@ayushmishra2005 @Dylan-DPC
Update src/librustc_error_codes/error_codes/E0628.md
f7fcb58 
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Minor change
00c6abe
Minor change
c33c88b
@ayushmishra2005
Copy link
Contributor Author

Hi @Dylan-DPC I have addressed all PR comments. Could you please review the changes? Thanks in advance.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2020

📌 Commit c33c88b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2020
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 14, 2020
Closed
100 tasks
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 16, 2020
Merged
bors added a commit that referenced this pull request Mar 16, 2020
@bors
Auto merge of #70040 - Dylan-DPC:rollup-id1k6lz, r=Dylan-DPC
59f4ba9 
Rollup of 7 pull requests

Successful merges:

 - #67335 (Refactor the `Qualif` trait)
 - #69122 (Backtrace Debug tweaks)
 - #69520 (Make error message clearer about creating new module)
 - #69738 (More Method -> AssocFn renaming)
 - #69867 (Add long error explanation for E0628 )
 - #69989 (resolve/hygiene: `macro_rules` are not "legacy")
 - #70036 (Make article_and_description primarily use def_kind)

Failed merges:

r? @ghost
@bors bors merged commit 8f2482b into rust-lang:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ayushmishra2005 @Dylan-DPC-zz @bors @davidtwco @GuillaumeGomez @JohnTitor