Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove framework in dataflow/mod.rs in favor of "generic" one #69644

Merged
merged 8 commits into from
Mar 27, 2020

Conversation

ecstatic-morse
Copy link
Contributor

@ecstatic-morse ecstatic-morse commented Mar 2, 2020

This is the culmination of the work described in rust-lang/compiler-team#202. All dataflow analyses (including the one in clippy) have been ported to use the framework in dataflow/generic, which can efficiently handle both gen/kill and generic problems. This PR moves the framework in dataflow/generic to dataflow/framework, and removes the gen/kill framework in dataflow/mod.rs.

More comprehensive documentation for the new framework is tracked in rust-lang/rustc-dev-guide#564.

clippy will need to change the path it uses to import the dataflow analysis traits.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2020
@ecstatic-morse
Copy link
Contributor Author

r? @pnkfelix

@bors
Copy link
Contributor

bors commented Mar 6, 2020

☔ The latest upstream changes (presumably #69746) made this pull request unmergeable. Please resolve the merge conflicts.

@ecstatic-morse
Copy link
Contributor Author

Ping @pnkfelix. I'll hold off on rebasing this again until it is reviewed since it is prone to merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 16, 2020

☔ The latest upstream changes (presumably #70040) made this pull request unmergeable. Please resolve the merge conflicts.

@ecstatic-morse
Copy link
Contributor Author

ping @pnkfelix

This is just removing dead code and renaming some modules. Can you reassign if you're not going to get to this?

@ecstatic-morse
Copy link
Contributor Author

Not sure what the hold up is. Can someone from @rust-lang/compiler review this?

r? @Mark-Simulacrum

@eddyb
Copy link
Member

eddyb commented Mar 26, 2020

r? @eddyb (feel free to ask me in PMs for reviews)

@eddyb
Copy link
Member

eddyb commented Mar 26, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2020

📌 Commit 89d6009 has been approved by eddyb

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 26, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#69644 (Remove framework in `dataflow/mod.rs` in favor of "generic" one)
 - rust-lang#69936 (Fix cycle error when emitting suggestion for mismatched `fn` type)
 - rust-lang#70048 (Allow obtaining &mut OsStr)
 - rust-lang#70344 (Decouple `rustc_hir::print` into `rustc_hir_pretty`)
 - rust-lang#70435 (Add regression test for rust-lang#66706)

Failed merges:

r? @ghost
@bors bors merged commit 0f6144a into rust-lang:master Mar 27, 2020
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Mar 27, 2020
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Mar 27, 2020
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Mar 27, 2020
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Mar 27, 2020
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 27, 2020
Changes:
````
remove redundant import
rustup rust-lang#68404
rustup rust-lang#69644
rustup rust-lang#70344
Move verbose_file_reads to restriction
move redundant_pub_crate to nursery
readme: explain how to run only a single lint on a codebase
Remove dependency on `matches` crate
Move useless_transmute to nursery
nursery group -> style
Update for PR feedback
Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them
````

Fixes rust-lang#70456
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2020
submodules: update clippy from 1ff81c1 to 70b93aa

Changes:
````
remove redundant import
rustup rust-lang#68404
rustup rust-lang#69644
rustup rust-lang#70344
Move verbose_file_reads to restriction
move redundant_pub_crate to nursery
readme: explain how to run only a single lint on a codebase
Remove dependency on `matches` crate
Move useless_transmute to nursery
nursery group -> style
Update for PR feedback
Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them
````

Fixes rust-lang#70456
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Apr 2, 2020
This was used by the old framework that was removed in rust-lang#69644.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 3, 2020
…eanup, r=nikomatsakis

Remove unused graphviz emitter

This was only used by the old dataflow framework that was removed in rust-lang#69644.
Centril added a commit to Centril/rust that referenced this pull request Apr 3, 2020
…eanup, r=nikomatsakis

Remove unused graphviz emitter

This was only used by the old dataflow framework that was removed in rust-lang#69644.
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 5, 2020
Changes:
````
remove redundant import
rustup rust-lang/rust#68404
rustup rust-lang/rust#69644
rustup rust-lang/rust#70344
Move verbose_file_reads to restriction
move redundant_pub_crate to nursery
readme: explain how to run only a single lint on a codebase
Remove dependency on `matches` crate
Move useless_transmute to nursery
nursery group -> style
Update for PR feedback
Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them
````

Fixes #70456
@ecstatic-morse ecstatic-morse deleted the unified-dataflow-cleanup branch October 6, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants