Use TypeRelating for instantiating query responses #69591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Mar 9, 2020
|
@bors r+ |
|
📌 Commit cbf5f7d has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2020
…, r=nikomatsakis Use TypeRelating for instantiating query responses `eq` can add constraints to `RegionConstraintData`, which isn't allowed during borrow checking outside of a `CustomTypeOp`. Use `TypeRelating` instead to always push constraints to the obligations list. closes rust-lang#69490
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2020
…, r=nikomatsakis Use TypeRelating for instantiating query responses `eq` can add constraints to `RegionConstraintData`, which isn't allowed during borrow checking outside of a `CustomTypeOp`. Use `TypeRelating` instead to always push constraints to the obligations list. closes rust-lang#69490
|
Beta just branched off, beta-nominating this. @rustbot modify labels: beta-nominated T-compiler |
rustbot
added
beta-nominated
bors
added a commit
that referenced
this pull request
Mar 10, 2020
Rollup of 6 pull requests Successful merges: - #69122 (Backtrace Debug tweaks) - #69591 (Use TypeRelating for instantiating query responses) - #69760 (Improve expression & attribute parsing) - #69837 (Use smaller discriminants for generators) - #69838 (Expansion-driven outline module parsing) - #69859 (fix #62456) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2020
…, r=nikomatsakis Use TypeRelating for instantiating query responses `eq` can add constraints to `RegionConstraintData`, which isn't allowed during borrow checking outside of a `CustomTypeOp`. Use `TypeRelating` instead to always push constraints to the obligations list. closes rust-lang#69490
bors
added a commit
that referenced
this pull request
Mar 11, 2020
Rollup of 10 pull requests Successful merges: - #66059 (mem::zeroed/uninit: panic on types that do not permit zero-initialization) - #69373 (Stabilize const for integer {to,from}_{be,le,ne}_bytes methods) - #69591 (Use TypeRelating for instantiating query responses) - #69625 (Implement nth, last, and count for iter::Copied) - #69645 (const forget tests) - #69766 (Make Point `Copy` in arithmetic documentation) - #69825 (make `mem::discriminant` const) - #69859 (fix #62456) - #69891 (Exhaustiveness checking, `Matrix::push`: recursively expand or-patterns) - #69896 (parse: Tweak the function parameter edition check) Failed merges: r? @ghost
|
Discussed at T-compiler meeting. beta-accepted. |
pnkfelix
added
the
beta-accepted
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2020
…ulacrum [beta] backports * Use TypeRelating for instantiating query responses rust-lang#69591 * Move rustc-guide submodule to rustc-dev-guide rust-lang#69898
Mark-Simulacrum
added
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eqcan add constraints toRegionConstraintData, which isn't allowed during borrow checking outside of aCustomTypeOp. UseTypeRelatinginstead to always push constraints to the obligations list.closes #69490