Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #68305

Merged
merged 31 commits into from
Jan 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3ab95ce
Detail transitive containment in E0588 diagnostic
varkor Jan 7, 2020
6fd5641
Specific error for unsized `dyn Trait` return type
estebank Jan 13, 2020
75eabb1
Account for diverging types in return `impl Trait`
estebank Jan 13, 2020
ea7e885
Elide E0308 errors in favor of E0746
estebank Jan 14, 2020
b4bbe78
Make `impl Trait` suggestion in E0746 `MachineApplicable`
estebank Jan 14, 2020
e1dd8a9
When trait bounds are missing for return values, point at them
estebank Jan 14, 2020
93293c5
fmt
estebank Jan 14, 2020
4c13d25
Add E0746 explanation to the index
estebank Jan 14, 2020
9dee5d5
fix rustfmt fallout
RalfJung Jan 3, 2020
00c8272
Split `librustc/traits/error_reporting.rs`
estebank Jan 14, 2020
4a75ef9
fix error code index comment
estebank Jan 14, 2020
5b36c18
review comments
estebank Jan 14, 2020
509cb33
review comments
estebank Jan 14, 2020
c305ac3
Fix error index test
estebank Jan 15, 2020
d7a6212
review comments
estebank Jan 15, 2020
00e2626
Account for object safety when suggesting `Box<dyn Trait>`
estebank Jan 15, 2020
3fd1af5
let rustfmt undo most of my edits :(
RalfJung Jan 3, 2020
c781d15
adjust Deref comment
RalfJung Jan 6, 2020
0f70daa
resolve: Move privacy error reporting into a separate method
petrochenkov Jan 12, 2020
28c3f6e
resolve: Point at the private item definitions in privacy errors
petrochenkov Jan 12, 2020
c84efe9
resolve: Say "import" when reporting private imports
petrochenkov Jan 12, 2020
0b60f1f
Ignore some tests on platforms without libstd spans
petrochenkov Jan 16, 2020
029a9c6
review comments
estebank Jan 16, 2020
7fbd30b
don't clone types that are copy
matthiaskrgr Jan 16, 2020
6246f7e
Don't propagate __RUST_TEST_INVOKE to subprocess
tmandry Jan 17, 2020
9f4b328
Rollup merge of #67956 - varkor:E0588-provide-context, r=estebank
Dylan-DPC Jan 17, 2020
ecf42a3
Rollup merge of #68153 - petrochenkov:privdiag, r=estebank
Dylan-DPC Jan 17, 2020
de01a29
Rollup merge of #68195 - estebank:impl-trait-2000, r=Centril
Dylan-DPC Jan 17, 2020
c411c22
Rollup merge of #68288 - RalfJung:fmt, r=oli-obk
Dylan-DPC Jan 17, 2020
5d55877
Rollup merge of #68292 - matthiaskrgr:clone_on_copy, r=eddyb
Dylan-DPC Jan 17, 2020
98347cd
Rollup merge of #68301 - tmandry:dont-propagate-test-invoke, r=alexcr…
Dylan-DPC Jan 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustc/infer/error_reporting/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2008,7 +2008,7 @@ impl<'tcx> ObligationCause<'tcx> {
TypeError::IntrinsicCast => {
Error0308("cannot coerce intrinsics to function pointers")
}
TypeError::ObjectUnsafeCoercion(did) => Error0038(did.clone()),
TypeError::ObjectUnsafeCoercion(did) => Error0038(*did),
_ => Error0308("mismatched types"),
},
}
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/mir/interpret/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl ErrorHandled {
ErrorHandled::Reported => {}
ErrorHandled::TooGeneric => bug!(
"MIR interpretation failed without reporting an error \
even though it was fully monomorphized"
even though it was fully monomorphized"
),
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/librustc/mir/interpret/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,8 @@ impl<'tcx> AllocMap<'tcx> {
let next = self.next_id;
self.next_id.0 = self.next_id.0.checked_add(1).expect(
"You overflowed a u64 by incrementing by 1... \
You've just earned yourself a free drink if we ever meet. \
Seriously, how did you do that?!",
You've just earned yourself a free drink if we ever meet. \
Seriously, how did you do that?!",
);
next
}
Expand Down
Loading