Clean up err codes #68247
Merged
Clean up err codes #68247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Dylan-DPC-zz
suggested changes
Jan 15, 2020
| @@ -1,4 +1,5 @@ | |||
| Your method's lifetime parameters do not match the trait declaration. | |||
| A method's lifetime parameters do not match the trait declaration. | |||
There was a problem hiding this comment.
Suggested change
| A method's lifetime parameters do not match the trait declaration. | |
| The lifetime parameters of the method do not match the trait declaration |
GuillaumeGomez
force-pushed
the
clean-up-err-codes
branch
from
82e99e1
to
6f1bdb4
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 6f1bdb4 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 19, 2020
…r=Dylan-DPC Clean up err codes r? @Dylan-DPC
bors
added a commit
that referenced
this pull request
Jan 19, 2020
Rollup of 5 pull requests Successful merges: - #67682 ([const-prop] Remove useless typedef) - #68133 (Slimmer syntax) - #68154 (Add more BTreeMap/BTreeSet benchmarks regarding iteration) - #68247 (Clean up err codes) - #68348 (Make iter::Empty<T> Send and Sync for any T) Failed merges: - #68353 (Remove `rustc_error_codes` deps except in `rustc_driver`) r? @ghost
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 19, 2020
…r=Dylan-DPC Clean up err codes r? @Dylan-DPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC